annotate gcc/ipa-inline-transform.c @ 120:f93fa5091070

fix conv1.c
author mir3636
date Thu, 08 Mar 2018 14:53:42 +0900
parents 04ced10e8804
children 84e7813d76e9
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
111
kono
parents:
diff changeset
1 /* Callgraph transformations to handle inlining
kono
parents:
diff changeset
2 Copyright (C) 2003-2017 Free Software Foundation, Inc.
kono
parents:
diff changeset
3 Contributed by Jan Hubicka
kono
parents:
diff changeset
4
kono
parents:
diff changeset
5 This file is part of GCC.
kono
parents:
diff changeset
6
kono
parents:
diff changeset
7 GCC is free software; you can redistribute it and/or modify it under
kono
parents:
diff changeset
8 the terms of the GNU General Public License as published by the Free
kono
parents:
diff changeset
9 Software Foundation; either version 3, or (at your option) any later
kono
parents:
diff changeset
10 version.
kono
parents:
diff changeset
11
kono
parents:
diff changeset
12 GCC is distributed in the hope that it will be useful, but WITHOUT ANY
kono
parents:
diff changeset
13 WARRANTY; without even the implied warranty of MERCHANTABILITY or
kono
parents:
diff changeset
14 FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
kono
parents:
diff changeset
15 for more details.
kono
parents:
diff changeset
16
kono
parents:
diff changeset
17 You should have received a copy of the GNU General Public License
kono
parents:
diff changeset
18 along with GCC; see the file COPYING3. If not see
kono
parents:
diff changeset
19 <http://www.gnu.org/licenses/>. */
kono
parents:
diff changeset
20
kono
parents:
diff changeset
21 /* The inline decisions are stored in callgraph in "inline plan" and
kono
parents:
diff changeset
22 applied later.
kono
parents:
diff changeset
23
kono
parents:
diff changeset
24 To mark given call inline, use inline_call function.
kono
parents:
diff changeset
25 The function marks the edge inlinable and, if necessary, produces
kono
parents:
diff changeset
26 virtual clone in the callgraph representing the new copy of callee's
kono
parents:
diff changeset
27 function body.
kono
parents:
diff changeset
28
kono
parents:
diff changeset
29 The inline plan is applied on given function body by inline_transform. */
kono
parents:
diff changeset
30
kono
parents:
diff changeset
31 #include "config.h"
kono
parents:
diff changeset
32 #include "system.h"
kono
parents:
diff changeset
33 #include "coretypes.h"
kono
parents:
diff changeset
34 #include "tm.h"
kono
parents:
diff changeset
35 #include "function.h"
kono
parents:
diff changeset
36 #include "tree.h"
kono
parents:
diff changeset
37 #include "alloc-pool.h"
kono
parents:
diff changeset
38 #include "tree-pass.h"
kono
parents:
diff changeset
39 #include "cgraph.h"
kono
parents:
diff changeset
40 #include "tree-cfg.h"
kono
parents:
diff changeset
41 #include "symbol-summary.h"
kono
parents:
diff changeset
42 #include "tree-vrp.h"
kono
parents:
diff changeset
43 #include "ipa-prop.h"
kono
parents:
diff changeset
44 #include "ipa-fnsummary.h"
kono
parents:
diff changeset
45 #include "ipa-inline.h"
kono
parents:
diff changeset
46 #include "tree-inline.h"
kono
parents:
diff changeset
47 #include "function.h"
kono
parents:
diff changeset
48 #include "cfg.h"
kono
parents:
diff changeset
49 #include "basic-block.h"
kono
parents:
diff changeset
50
kono
parents:
diff changeset
51 int ncalls_inlined;
kono
parents:
diff changeset
52 int nfunctions_inlined;
kono
parents:
diff changeset
53
kono
parents:
diff changeset
54 /* Scale frequency of NODE edges by FREQ_SCALE. */
kono
parents:
diff changeset
55
kono
parents:
diff changeset
56 static void
kono
parents:
diff changeset
57 update_noncloned_frequencies (struct cgraph_node *node,
kono
parents:
diff changeset
58 int freq_scale, profile_count num,
kono
parents:
diff changeset
59 profile_count den)
kono
parents:
diff changeset
60 {
kono
parents:
diff changeset
61 struct cgraph_edge *e;
kono
parents:
diff changeset
62 bool scale = (num == profile_count::zero () || den > 0);
kono
parents:
diff changeset
63
kono
parents:
diff changeset
64 /* We do not want to ignore high loop nest after freq drops to 0. */
kono
parents:
diff changeset
65 if (!freq_scale)
kono
parents:
diff changeset
66 freq_scale = 1;
kono
parents:
diff changeset
67 for (e = node->callees; e; e = e->next_callee)
kono
parents:
diff changeset
68 {
kono
parents:
diff changeset
69 e->frequency = e->frequency * (gcov_type) freq_scale / CGRAPH_FREQ_BASE;
kono
parents:
diff changeset
70 if (e->frequency > CGRAPH_FREQ_MAX)
kono
parents:
diff changeset
71 e->frequency = CGRAPH_FREQ_MAX;
kono
parents:
diff changeset
72 if (!e->inline_failed)
kono
parents:
diff changeset
73 update_noncloned_frequencies (e->callee, freq_scale, num, den);
kono
parents:
diff changeset
74 if (scale)
kono
parents:
diff changeset
75 e->count = e->count.apply_scale (num, den);
kono
parents:
diff changeset
76 }
kono
parents:
diff changeset
77 for (e = node->indirect_calls; e; e = e->next_callee)
kono
parents:
diff changeset
78 {
kono
parents:
diff changeset
79 e->frequency = e->frequency * (gcov_type) freq_scale / CGRAPH_FREQ_BASE;
kono
parents:
diff changeset
80 if (e->frequency > CGRAPH_FREQ_MAX)
kono
parents:
diff changeset
81 e->frequency = CGRAPH_FREQ_MAX;
kono
parents:
diff changeset
82 if (scale)
kono
parents:
diff changeset
83 e->count = e->count.apply_scale (num, den);
kono
parents:
diff changeset
84 }
kono
parents:
diff changeset
85 if (scale)
kono
parents:
diff changeset
86 node->count = node->count.apply_scale (num, den);
kono
parents:
diff changeset
87 }
kono
parents:
diff changeset
88
kono
parents:
diff changeset
89 /* We removed or are going to remove the last call to NODE.
kono
parents:
diff changeset
90 Return true if we can and want proactively remove the NODE now.
kono
parents:
diff changeset
91 This is important to do, since we want inliner to know when offline
kono
parents:
diff changeset
92 copy of function was removed. */
kono
parents:
diff changeset
93
kono
parents:
diff changeset
94 static bool
kono
parents:
diff changeset
95 can_remove_node_now_p_1 (struct cgraph_node *node, struct cgraph_edge *e)
kono
parents:
diff changeset
96 {
kono
parents:
diff changeset
97 ipa_ref *ref;
kono
parents:
diff changeset
98
kono
parents:
diff changeset
99 FOR_EACH_ALIAS (node, ref)
kono
parents:
diff changeset
100 {
kono
parents:
diff changeset
101 cgraph_node *alias = dyn_cast <cgraph_node *> (ref->referring);
kono
parents:
diff changeset
102 if ((alias->callers && alias->callers != e)
kono
parents:
diff changeset
103 || !can_remove_node_now_p_1 (alias, e))
kono
parents:
diff changeset
104 return false;
kono
parents:
diff changeset
105 }
kono
parents:
diff changeset
106 /* FIXME: When address is taken of DECL_EXTERNAL function we still
kono
parents:
diff changeset
107 can remove its offline copy, but we would need to keep unanalyzed node in
kono
parents:
diff changeset
108 the callgraph so references can point to it.
kono
parents:
diff changeset
109
kono
parents:
diff changeset
110 Also for comdat group we can ignore references inside a group as we
kono
parents:
diff changeset
111 want to prove the group as a whole to be dead. */
kono
parents:
diff changeset
112 return (!node->address_taken
kono
parents:
diff changeset
113 && node->can_remove_if_no_direct_calls_and_refs_p ()
kono
parents:
diff changeset
114 /* Inlining might enable more devirtualizing, so we want to remove
kono
parents:
diff changeset
115 those only after all devirtualizable virtual calls are processed.
kono
parents:
diff changeset
116 Lacking may edges in callgraph we just preserve them post
kono
parents:
diff changeset
117 inlining. */
kono
parents:
diff changeset
118 && (!DECL_VIRTUAL_P (node->decl)
kono
parents:
diff changeset
119 || !opt_for_fn (node->decl, flag_devirtualize))
kono
parents:
diff changeset
120 /* During early inlining some unanalyzed cgraph nodes might be in the
kono
parents:
diff changeset
121 callgraph and they might reffer the function in question. */
kono
parents:
diff changeset
122 && !cgraph_new_nodes.exists ());
kono
parents:
diff changeset
123 }
kono
parents:
diff changeset
124
kono
parents:
diff changeset
125 /* We are going to eliminate last direct call to NODE (or alias of it) via edge E.
kono
parents:
diff changeset
126 Verify that the NODE can be removed from unit and if it is contained in comdat
kono
parents:
diff changeset
127 group that the whole comdat group is removable. */
kono
parents:
diff changeset
128
kono
parents:
diff changeset
129 static bool
kono
parents:
diff changeset
130 can_remove_node_now_p (struct cgraph_node *node, struct cgraph_edge *e)
kono
parents:
diff changeset
131 {
kono
parents:
diff changeset
132 struct cgraph_node *next;
kono
parents:
diff changeset
133 if (!can_remove_node_now_p_1 (node, e))
kono
parents:
diff changeset
134 return false;
kono
parents:
diff changeset
135
kono
parents:
diff changeset
136 /* When we see same comdat group, we need to be sure that all
kono
parents:
diff changeset
137 items can be removed. */
kono
parents:
diff changeset
138 if (!node->same_comdat_group || !node->externally_visible)
kono
parents:
diff changeset
139 return true;
kono
parents:
diff changeset
140 for (next = dyn_cast<cgraph_node *> (node->same_comdat_group);
kono
parents:
diff changeset
141 next != node; next = dyn_cast<cgraph_node *> (next->same_comdat_group))
kono
parents:
diff changeset
142 {
kono
parents:
diff changeset
143 if (next->alias)
kono
parents:
diff changeset
144 continue;
kono
parents:
diff changeset
145 if ((next->callers && next->callers != e)
kono
parents:
diff changeset
146 || !can_remove_node_now_p_1 (next, e))
kono
parents:
diff changeset
147 return false;
kono
parents:
diff changeset
148 }
kono
parents:
diff changeset
149 return true;
kono
parents:
diff changeset
150 }
kono
parents:
diff changeset
151
kono
parents:
diff changeset
152 /* Return true if NODE is a master clone with non-inline clones. */
kono
parents:
diff changeset
153
kono
parents:
diff changeset
154 static bool
kono
parents:
diff changeset
155 master_clone_with_noninline_clones_p (struct cgraph_node *node)
kono
parents:
diff changeset
156 {
kono
parents:
diff changeset
157 if (node->clone_of)
kono
parents:
diff changeset
158 return false;
kono
parents:
diff changeset
159
kono
parents:
diff changeset
160 for (struct cgraph_node *n = node->clones; n; n = n->next_sibling_clone)
kono
parents:
diff changeset
161 if (n->decl != node->decl)
kono
parents:
diff changeset
162 return true;
kono
parents:
diff changeset
163
kono
parents:
diff changeset
164 return false;
kono
parents:
diff changeset
165 }
kono
parents:
diff changeset
166
kono
parents:
diff changeset
167 /* E is expected to be an edge being inlined. Clone destination node of
kono
parents:
diff changeset
168 the edge and redirect it to the new clone.
kono
parents:
diff changeset
169 DUPLICATE is used for bookkeeping on whether we are actually creating new
kono
parents:
diff changeset
170 clones or re-using node originally representing out-of-line function call.
kono
parents:
diff changeset
171 By default the offline copy is removed, when it appears dead after inlining.
kono
parents:
diff changeset
172 UPDATE_ORIGINAL prevents this transformation.
kono
parents:
diff changeset
173 If OVERALL_SIZE is non-NULL, the size is updated to reflect the
kono
parents:
diff changeset
174 transformation.
kono
parents:
diff changeset
175 FREQ_SCALE specify the scaling of frequencies of call sites. */
kono
parents:
diff changeset
176
kono
parents:
diff changeset
177 void
kono
parents:
diff changeset
178 clone_inlined_nodes (struct cgraph_edge *e, bool duplicate,
kono
parents:
diff changeset
179 bool update_original, int *overall_size, int freq_scale)
kono
parents:
diff changeset
180 {
kono
parents:
diff changeset
181 struct cgraph_node *inlining_into;
kono
parents:
diff changeset
182 struct cgraph_edge *next;
kono
parents:
diff changeset
183
kono
parents:
diff changeset
184 if (e->caller->global.inlined_to)
kono
parents:
diff changeset
185 inlining_into = e->caller->global.inlined_to;
kono
parents:
diff changeset
186 else
kono
parents:
diff changeset
187 inlining_into = e->caller;
kono
parents:
diff changeset
188
kono
parents:
diff changeset
189 if (duplicate)
kono
parents:
diff changeset
190 {
kono
parents:
diff changeset
191 /* We may eliminate the need for out-of-line copy to be output.
kono
parents:
diff changeset
192 In that case just go ahead and re-use it. This is not just an
kono
parents:
diff changeset
193 memory optimization. Making offline copy of fuction disappear
kono
parents:
diff changeset
194 from the program will improve future decisions on inlining. */
kono
parents:
diff changeset
195 if (!e->callee->callers->next_caller
kono
parents:
diff changeset
196 /* Recursive inlining never wants the master clone to
kono
parents:
diff changeset
197 be overwritten. */
kono
parents:
diff changeset
198 && update_original
kono
parents:
diff changeset
199 && can_remove_node_now_p (e->callee, e)
kono
parents:
diff changeset
200 /* We cannot overwrite a master clone with non-inline clones
kono
parents:
diff changeset
201 until after these clones are materialized. */
kono
parents:
diff changeset
202 && !master_clone_with_noninline_clones_p (e->callee))
kono
parents:
diff changeset
203 {
kono
parents:
diff changeset
204 /* TODO: When callee is in a comdat group, we could remove all of it,
kono
parents:
diff changeset
205 including all inline clones inlined into it. That would however
kono
parents:
diff changeset
206 need small function inlining to register edge removal hook to
kono
parents:
diff changeset
207 maintain the priority queue.
kono
parents:
diff changeset
208
kono
parents:
diff changeset
209 For now we keep the ohter functions in the group in program until
kono
parents:
diff changeset
210 cgraph_remove_unreachable_functions gets rid of them. */
kono
parents:
diff changeset
211 gcc_assert (!e->callee->global.inlined_to);
kono
parents:
diff changeset
212 e->callee->remove_from_same_comdat_group ();
kono
parents:
diff changeset
213 if (e->callee->definition
kono
parents:
diff changeset
214 && inline_account_function_p (e->callee))
kono
parents:
diff changeset
215 {
kono
parents:
diff changeset
216 gcc_assert (!e->callee->alias);
kono
parents:
diff changeset
217 if (overall_size)
kono
parents:
diff changeset
218 *overall_size -= ipa_fn_summaries->get (e->callee)->size;
kono
parents:
diff changeset
219 nfunctions_inlined++;
kono
parents:
diff changeset
220 }
kono
parents:
diff changeset
221 duplicate = false;
kono
parents:
diff changeset
222 e->callee->externally_visible = false;
kono
parents:
diff changeset
223 update_noncloned_frequencies (e->callee, e->frequency,
kono
parents:
diff changeset
224 e->count, e->callee->count);
kono
parents:
diff changeset
225
kono
parents:
diff changeset
226 dump_callgraph_transformation (e->callee, inlining_into,
kono
parents:
diff changeset
227 "inlining to");
kono
parents:
diff changeset
228 }
kono
parents:
diff changeset
229 else
kono
parents:
diff changeset
230 {
kono
parents:
diff changeset
231 struct cgraph_node *n;
kono
parents:
diff changeset
232
kono
parents:
diff changeset
233 if (freq_scale == -1)
kono
parents:
diff changeset
234 freq_scale = e->frequency;
kono
parents:
diff changeset
235 n = e->callee->create_clone (e->callee->decl,
kono
parents:
diff changeset
236 MIN (e->count, e->callee->count),
kono
parents:
diff changeset
237 freq_scale,
kono
parents:
diff changeset
238 update_original, vNULL, true,
kono
parents:
diff changeset
239 inlining_into,
kono
parents:
diff changeset
240 NULL);
kono
parents:
diff changeset
241 n->used_as_abstract_origin = e->callee->used_as_abstract_origin;
kono
parents:
diff changeset
242 e->redirect_callee (n);
kono
parents:
diff changeset
243 }
kono
parents:
diff changeset
244 }
kono
parents:
diff changeset
245 else
kono
parents:
diff changeset
246 e->callee->remove_from_same_comdat_group ();
kono
parents:
diff changeset
247
kono
parents:
diff changeset
248 e->callee->global.inlined_to = inlining_into;
kono
parents:
diff changeset
249
kono
parents:
diff changeset
250 /* Recursively clone all bodies. */
kono
parents:
diff changeset
251 for (e = e->callee->callees; e; e = next)
kono
parents:
diff changeset
252 {
kono
parents:
diff changeset
253 next = e->next_callee;
kono
parents:
diff changeset
254 if (!e->inline_failed)
kono
parents:
diff changeset
255 clone_inlined_nodes (e, duplicate, update_original, overall_size, freq_scale);
kono
parents:
diff changeset
256 }
kono
parents:
diff changeset
257 }
kono
parents:
diff changeset
258
kono
parents:
diff changeset
259 /* Check all speculations in N and resolve them if they seems useless. */
kono
parents:
diff changeset
260
kono
parents:
diff changeset
261 static bool
kono
parents:
diff changeset
262 check_speculations (cgraph_node *n)
kono
parents:
diff changeset
263 {
kono
parents:
diff changeset
264 bool speculation_removed = false;
kono
parents:
diff changeset
265 cgraph_edge *next;
kono
parents:
diff changeset
266
kono
parents:
diff changeset
267 for (cgraph_edge *e = n->callees; e; e = next)
kono
parents:
diff changeset
268 {
kono
parents:
diff changeset
269 next = e->next_callee;
kono
parents:
diff changeset
270 if (e->speculative && !speculation_useful_p (e, true))
kono
parents:
diff changeset
271 {
kono
parents:
diff changeset
272 e->resolve_speculation (NULL);
kono
parents:
diff changeset
273 speculation_removed = true;
kono
parents:
diff changeset
274 }
kono
parents:
diff changeset
275 else if (!e->inline_failed)
kono
parents:
diff changeset
276 speculation_removed |= check_speculations (e->callee);
kono
parents:
diff changeset
277 }
kono
parents:
diff changeset
278 return speculation_removed;
kono
parents:
diff changeset
279 }
kono
parents:
diff changeset
280
kono
parents:
diff changeset
281 /* Mark all call graph edges coming out of NODE and all nodes that have been
kono
parents:
diff changeset
282 inlined to it as in_polymorphic_cdtor. */
kono
parents:
diff changeset
283
kono
parents:
diff changeset
284 static void
kono
parents:
diff changeset
285 mark_all_inlined_calls_cdtor (cgraph_node *node)
kono
parents:
diff changeset
286 {
kono
parents:
diff changeset
287 for (cgraph_edge *cs = node->callees; cs; cs = cs->next_callee)
kono
parents:
diff changeset
288 {
kono
parents:
diff changeset
289 cs->in_polymorphic_cdtor = true;
kono
parents:
diff changeset
290 if (!cs->inline_failed)
kono
parents:
diff changeset
291 mark_all_inlined_calls_cdtor (cs->callee);
kono
parents:
diff changeset
292 }
kono
parents:
diff changeset
293 for (cgraph_edge *cs = node->indirect_calls; cs; cs = cs->next_callee)
kono
parents:
diff changeset
294 cs->in_polymorphic_cdtor = true;
kono
parents:
diff changeset
295 }
kono
parents:
diff changeset
296
kono
parents:
diff changeset
297
kono
parents:
diff changeset
298 /* Mark edge E as inlined and update callgraph accordingly. UPDATE_ORIGINAL
kono
parents:
diff changeset
299 specify whether profile of original function should be updated. If any new
kono
parents:
diff changeset
300 indirect edges are discovered in the process, add them to NEW_EDGES, unless
kono
parents:
diff changeset
301 it is NULL. If UPDATE_OVERALL_SUMMARY is false, do not bother to recompute overall
kono
parents:
diff changeset
302 size of caller after inlining. Caller is required to eventually do it via
kono
parents:
diff changeset
303 ipa_update_overall_fn_summary.
kono
parents:
diff changeset
304 If callee_removed is non-NULL, set it to true if we removed callee node.
kono
parents:
diff changeset
305
kono
parents:
diff changeset
306 Return true iff any new callgraph edges were discovered as a
kono
parents:
diff changeset
307 result of inlining. */
kono
parents:
diff changeset
308
kono
parents:
diff changeset
309 bool
kono
parents:
diff changeset
310 inline_call (struct cgraph_edge *e, bool update_original,
kono
parents:
diff changeset
311 vec<cgraph_edge *> *new_edges,
kono
parents:
diff changeset
312 int *overall_size, bool update_overall_summary,
kono
parents:
diff changeset
313 bool *callee_removed)
kono
parents:
diff changeset
314 {
kono
parents:
diff changeset
315 int old_size = 0, new_size = 0;
kono
parents:
diff changeset
316 struct cgraph_node *to = NULL;
kono
parents:
diff changeset
317 struct cgraph_edge *curr = e;
kono
parents:
diff changeset
318 struct cgraph_node *callee = e->callee->ultimate_alias_target ();
kono
parents:
diff changeset
319 bool new_edges_found = false;
kono
parents:
diff changeset
320
kono
parents:
diff changeset
321 int estimated_growth = 0;
kono
parents:
diff changeset
322 if (! update_overall_summary)
kono
parents:
diff changeset
323 estimated_growth = estimate_edge_growth (e);
kono
parents:
diff changeset
324 /* This is used only for assert bellow. */
kono
parents:
diff changeset
325 #if 0
kono
parents:
diff changeset
326 bool predicated = inline_edge_summary (e)->predicate != NULL;
kono
parents:
diff changeset
327 #endif
kono
parents:
diff changeset
328
kono
parents:
diff changeset
329 /* Don't inline inlined edges. */
kono
parents:
diff changeset
330 gcc_assert (e->inline_failed);
kono
parents:
diff changeset
331 /* Don't even think of inlining inline clone. */
kono
parents:
diff changeset
332 gcc_assert (!callee->global.inlined_to);
kono
parents:
diff changeset
333
kono
parents:
diff changeset
334 to = e->caller;
kono
parents:
diff changeset
335 if (to->global.inlined_to)
kono
parents:
diff changeset
336 to = to->global.inlined_to;
kono
parents:
diff changeset
337 if (to->thunk.thunk_p)
kono
parents:
diff changeset
338 {
kono
parents:
diff changeset
339 struct cgraph_node *target = to->callees->callee;
kono
parents:
diff changeset
340 if (in_lto_p)
kono
parents:
diff changeset
341 to->get_untransformed_body ();
kono
parents:
diff changeset
342 to->expand_thunk (false, true);
kono
parents:
diff changeset
343 /* When thunk is instrumented we may have multiple callees. */
kono
parents:
diff changeset
344 for (e = to->callees; e && e->callee != target; e = e->next_callee)
kono
parents:
diff changeset
345 ;
kono
parents:
diff changeset
346 gcc_assert (e);
kono
parents:
diff changeset
347 }
kono
parents:
diff changeset
348
kono
parents:
diff changeset
349
kono
parents:
diff changeset
350 e->inline_failed = CIF_OK;
kono
parents:
diff changeset
351 DECL_POSSIBLY_INLINED (callee->decl) = true;
kono
parents:
diff changeset
352
kono
parents:
diff changeset
353 if (DECL_FUNCTION_PERSONALITY (callee->decl))
kono
parents:
diff changeset
354 DECL_FUNCTION_PERSONALITY (to->decl)
kono
parents:
diff changeset
355 = DECL_FUNCTION_PERSONALITY (callee->decl);
kono
parents:
diff changeset
356
kono
parents:
diff changeset
357 bool reload_optimization_node = false;
kono
parents:
diff changeset
358 if (!opt_for_fn (callee->decl, flag_strict_aliasing)
kono
parents:
diff changeset
359 && opt_for_fn (to->decl, flag_strict_aliasing))
kono
parents:
diff changeset
360 {
kono
parents:
diff changeset
361 struct gcc_options opts = global_options;
kono
parents:
diff changeset
362
kono
parents:
diff changeset
363 cl_optimization_restore (&opts, opts_for_fn (to->decl));
kono
parents:
diff changeset
364 opts.x_flag_strict_aliasing = false;
kono
parents:
diff changeset
365 if (dump_file)
kono
parents:
diff changeset
366 fprintf (dump_file, "Dropping flag_strict_aliasing on %s\n",
kono
parents:
diff changeset
367 to->dump_name ());
kono
parents:
diff changeset
368 DECL_FUNCTION_SPECIFIC_OPTIMIZATION (to->decl)
kono
parents:
diff changeset
369 = build_optimization_node (&opts);
kono
parents:
diff changeset
370 reload_optimization_node = true;
kono
parents:
diff changeset
371 }
kono
parents:
diff changeset
372
kono
parents:
diff changeset
373 ipa_fn_summary *caller_info = ipa_fn_summaries->get (to);
kono
parents:
diff changeset
374 ipa_fn_summary *callee_info = ipa_fn_summaries->get (callee);
kono
parents:
diff changeset
375 if (!caller_info->fp_expressions && callee_info->fp_expressions)
kono
parents:
diff changeset
376 {
kono
parents:
diff changeset
377 caller_info->fp_expressions = true;
kono
parents:
diff changeset
378 if (opt_for_fn (callee->decl, flag_rounding_math)
kono
parents:
diff changeset
379 != opt_for_fn (to->decl, flag_rounding_math)
kono
parents:
diff changeset
380 || opt_for_fn (callee->decl, flag_trapping_math)
kono
parents:
diff changeset
381 != opt_for_fn (to->decl, flag_trapping_math)
kono
parents:
diff changeset
382 || opt_for_fn (callee->decl, flag_unsafe_math_optimizations)
kono
parents:
diff changeset
383 != opt_for_fn (to->decl, flag_unsafe_math_optimizations)
kono
parents:
diff changeset
384 || opt_for_fn (callee->decl, flag_finite_math_only)
kono
parents:
diff changeset
385 != opt_for_fn (to->decl, flag_finite_math_only)
kono
parents:
diff changeset
386 || opt_for_fn (callee->decl, flag_signaling_nans)
kono
parents:
diff changeset
387 != opt_for_fn (to->decl, flag_signaling_nans)
kono
parents:
diff changeset
388 || opt_for_fn (callee->decl, flag_cx_limited_range)
kono
parents:
diff changeset
389 != opt_for_fn (to->decl, flag_cx_limited_range)
kono
parents:
diff changeset
390 || opt_for_fn (callee->decl, flag_signed_zeros)
kono
parents:
diff changeset
391 != opt_for_fn (to->decl, flag_signed_zeros)
kono
parents:
diff changeset
392 || opt_for_fn (callee->decl, flag_associative_math)
kono
parents:
diff changeset
393 != opt_for_fn (to->decl, flag_associative_math)
kono
parents:
diff changeset
394 || opt_for_fn (callee->decl, flag_reciprocal_math)
kono
parents:
diff changeset
395 != opt_for_fn (to->decl, flag_reciprocal_math)
kono
parents:
diff changeset
396 || opt_for_fn (callee->decl, flag_fp_int_builtin_inexact)
kono
parents:
diff changeset
397 != opt_for_fn (to->decl, flag_fp_int_builtin_inexact)
kono
parents:
diff changeset
398 || opt_for_fn (callee->decl, flag_errno_math)
kono
parents:
diff changeset
399 != opt_for_fn (to->decl, flag_errno_math))
kono
parents:
diff changeset
400 {
kono
parents:
diff changeset
401 struct gcc_options opts = global_options;
kono
parents:
diff changeset
402
kono
parents:
diff changeset
403 cl_optimization_restore (&opts, opts_for_fn (to->decl));
kono
parents:
diff changeset
404 opts.x_flag_rounding_math
kono
parents:
diff changeset
405 = opt_for_fn (callee->decl, flag_rounding_math);
kono
parents:
diff changeset
406 opts.x_flag_trapping_math
kono
parents:
diff changeset
407 = opt_for_fn (callee->decl, flag_trapping_math);
kono
parents:
diff changeset
408 opts.x_flag_unsafe_math_optimizations
kono
parents:
diff changeset
409 = opt_for_fn (callee->decl, flag_unsafe_math_optimizations);
kono
parents:
diff changeset
410 opts.x_flag_finite_math_only
kono
parents:
diff changeset
411 = opt_for_fn (callee->decl, flag_finite_math_only);
kono
parents:
diff changeset
412 opts.x_flag_signaling_nans
kono
parents:
diff changeset
413 = opt_for_fn (callee->decl, flag_signaling_nans);
kono
parents:
diff changeset
414 opts.x_flag_cx_limited_range
kono
parents:
diff changeset
415 = opt_for_fn (callee->decl, flag_cx_limited_range);
kono
parents:
diff changeset
416 opts.x_flag_signed_zeros
kono
parents:
diff changeset
417 = opt_for_fn (callee->decl, flag_signed_zeros);
kono
parents:
diff changeset
418 opts.x_flag_associative_math
kono
parents:
diff changeset
419 = opt_for_fn (callee->decl, flag_associative_math);
kono
parents:
diff changeset
420 opts.x_flag_reciprocal_math
kono
parents:
diff changeset
421 = opt_for_fn (callee->decl, flag_reciprocal_math);
kono
parents:
diff changeset
422 opts.x_flag_fp_int_builtin_inexact
kono
parents:
diff changeset
423 = opt_for_fn (callee->decl, flag_fp_int_builtin_inexact);
kono
parents:
diff changeset
424 opts.x_flag_errno_math
kono
parents:
diff changeset
425 = opt_for_fn (callee->decl, flag_errno_math);
kono
parents:
diff changeset
426 if (dump_file)
kono
parents:
diff changeset
427 fprintf (dump_file, "Copying FP flags from %s to %s\n",
kono
parents:
diff changeset
428 callee->dump_name (), to->dump_name ());
kono
parents:
diff changeset
429 DECL_FUNCTION_SPECIFIC_OPTIMIZATION (to->decl)
kono
parents:
diff changeset
430 = build_optimization_node (&opts);
kono
parents:
diff changeset
431 reload_optimization_node = true;
kono
parents:
diff changeset
432 }
kono
parents:
diff changeset
433 }
kono
parents:
diff changeset
434
kono
parents:
diff changeset
435 /* Reload global optimization flags. */
kono
parents:
diff changeset
436 if (reload_optimization_node && DECL_STRUCT_FUNCTION (to->decl) == cfun)
kono
parents:
diff changeset
437 set_cfun (cfun, true);
kono
parents:
diff changeset
438
kono
parents:
diff changeset
439 /* If aliases are involved, redirect edge to the actual destination and
kono
parents:
diff changeset
440 possibly remove the aliases. */
kono
parents:
diff changeset
441 if (e->callee != callee)
kono
parents:
diff changeset
442 {
kono
parents:
diff changeset
443 struct cgraph_node *alias = e->callee, *next_alias;
kono
parents:
diff changeset
444 e->redirect_callee (callee);
kono
parents:
diff changeset
445 while (alias && alias != callee)
kono
parents:
diff changeset
446 {
kono
parents:
diff changeset
447 if (!alias->callers
kono
parents:
diff changeset
448 && can_remove_node_now_p (alias,
kono
parents:
diff changeset
449 !e->next_caller && !e->prev_caller ? e : NULL))
kono
parents:
diff changeset
450 {
kono
parents:
diff changeset
451 next_alias = alias->get_alias_target ();
kono
parents:
diff changeset
452 alias->remove ();
kono
parents:
diff changeset
453 if (callee_removed)
kono
parents:
diff changeset
454 *callee_removed = true;
kono
parents:
diff changeset
455 alias = next_alias;
kono
parents:
diff changeset
456 }
kono
parents:
diff changeset
457 else
kono
parents:
diff changeset
458 break;
kono
parents:
diff changeset
459 }
kono
parents:
diff changeset
460 }
kono
parents:
diff changeset
461
kono
parents:
diff changeset
462 clone_inlined_nodes (e, true, update_original, overall_size, e->frequency);
kono
parents:
diff changeset
463
kono
parents:
diff changeset
464 gcc_assert (curr->callee->global.inlined_to == to);
kono
parents:
diff changeset
465
kono
parents:
diff changeset
466 old_size = ipa_fn_summaries->get (to)->size;
kono
parents:
diff changeset
467 ipa_merge_fn_summary_after_inlining (e);
kono
parents:
diff changeset
468 if (e->in_polymorphic_cdtor)
kono
parents:
diff changeset
469 mark_all_inlined_calls_cdtor (e->callee);
kono
parents:
diff changeset
470 if (opt_for_fn (e->caller->decl, optimize))
kono
parents:
diff changeset
471 new_edges_found = ipa_propagate_indirect_call_infos (curr, new_edges);
kono
parents:
diff changeset
472 check_speculations (e->callee);
kono
parents:
diff changeset
473 if (update_overall_summary)
kono
parents:
diff changeset
474 ipa_update_overall_fn_summary (to);
kono
parents:
diff changeset
475 else
kono
parents:
diff changeset
476 /* Update self size by the estimate so overall function growth limits
kono
parents:
diff changeset
477 work for further inlining into this function. Before inlining
kono
parents:
diff changeset
478 the function we inlined to again we expect the caller to update
kono
parents:
diff changeset
479 the overall summary. */
kono
parents:
diff changeset
480 ipa_fn_summaries->get (to)->size += estimated_growth;
kono
parents:
diff changeset
481 new_size = ipa_fn_summaries->get (to)->size;
kono
parents:
diff changeset
482
kono
parents:
diff changeset
483 if (callee->calls_comdat_local)
kono
parents:
diff changeset
484 to->calls_comdat_local = true;
kono
parents:
diff changeset
485 else if (to->calls_comdat_local && callee->comdat_local_p ())
kono
parents:
diff changeset
486 {
kono
parents:
diff changeset
487 struct cgraph_edge *se = to->callees;
kono
parents:
diff changeset
488 for (; se; se = se->next_callee)
kono
parents:
diff changeset
489 if (se->inline_failed && se->callee->comdat_local_p ())
kono
parents:
diff changeset
490 break;
kono
parents:
diff changeset
491 if (se == NULL)
kono
parents:
diff changeset
492 to->calls_comdat_local = false;
kono
parents:
diff changeset
493 }
kono
parents:
diff changeset
494
kono
parents:
diff changeset
495 /* FIXME: This assert suffers from roundoff errors, disable it for GCC 5
kono
parents:
diff changeset
496 and revisit it after conversion to sreals in GCC 6.
kono
parents:
diff changeset
497 See PR 65654. */
kono
parents:
diff changeset
498 #if 0
kono
parents:
diff changeset
499 /* Verify that estimated growth match real growth. Allow off-by-one
kono
parents:
diff changeset
500 error due to ipa_fn_summary::size_scale roudoff errors. */
kono
parents:
diff changeset
501 gcc_assert (!update_overall_summary || !overall_size || new_edges_found
kono
parents:
diff changeset
502 || abs (estimated_growth - (new_size - old_size)) <= 1
kono
parents:
diff changeset
503 || speculation_removed
kono
parents:
diff changeset
504 /* FIXME: a hack. Edges with false predicate are accounted
kono
parents:
diff changeset
505 wrong, we should remove them from callgraph. */
kono
parents:
diff changeset
506 || predicated);
kono
parents:
diff changeset
507 #endif
kono
parents:
diff changeset
508
kono
parents:
diff changeset
509 /* Account the change of overall unit size; external functions will be
kono
parents:
diff changeset
510 removed and are thus not accounted. */
kono
parents:
diff changeset
511 if (overall_size && inline_account_function_p (to))
kono
parents:
diff changeset
512 *overall_size += new_size - old_size;
kono
parents:
diff changeset
513 ncalls_inlined++;
kono
parents:
diff changeset
514
kono
parents:
diff changeset
515 /* This must happen after ipa_merge_fn_summary_after_inlining that rely on jump
kono
parents:
diff changeset
516 functions of callee to not be updated. */
kono
parents:
diff changeset
517 return new_edges_found;
kono
parents:
diff changeset
518 }
kono
parents:
diff changeset
519
kono
parents:
diff changeset
520
kono
parents:
diff changeset
521 /* Copy function body of NODE and redirect all inline clones to it.
kono
parents:
diff changeset
522 This is done before inline plan is applied to NODE when there are
kono
parents:
diff changeset
523 still some inline clones if it.
kono
parents:
diff changeset
524
kono
parents:
diff changeset
525 This is necessary because inline decisions are not really transitive
kono
parents:
diff changeset
526 and the other inline clones may have different bodies. */
kono
parents:
diff changeset
527
kono
parents:
diff changeset
528 static struct cgraph_node *
kono
parents:
diff changeset
529 save_inline_function_body (struct cgraph_node *node)
kono
parents:
diff changeset
530 {
kono
parents:
diff changeset
531 struct cgraph_node *first_clone, *n;
kono
parents:
diff changeset
532
kono
parents:
diff changeset
533 if (dump_file)
kono
parents:
diff changeset
534 fprintf (dump_file, "\nSaving body of %s for later reuse\n",
kono
parents:
diff changeset
535 node->name ());
kono
parents:
diff changeset
536
kono
parents:
diff changeset
537 gcc_assert (node == cgraph_node::get (node->decl));
kono
parents:
diff changeset
538
kono
parents:
diff changeset
539 /* first_clone will be turned into real function. */
kono
parents:
diff changeset
540 first_clone = node->clones;
kono
parents:
diff changeset
541
kono
parents:
diff changeset
542 /* Arrange first clone to not be thunk as those do not have bodies. */
kono
parents:
diff changeset
543 if (first_clone->thunk.thunk_p)
kono
parents:
diff changeset
544 {
kono
parents:
diff changeset
545 while (first_clone->thunk.thunk_p)
kono
parents:
diff changeset
546 first_clone = first_clone->next_sibling_clone;
kono
parents:
diff changeset
547 first_clone->prev_sibling_clone->next_sibling_clone
kono
parents:
diff changeset
548 = first_clone->next_sibling_clone;
kono
parents:
diff changeset
549 if (first_clone->next_sibling_clone)
kono
parents:
diff changeset
550 first_clone->next_sibling_clone->prev_sibling_clone
kono
parents:
diff changeset
551 = first_clone->prev_sibling_clone;
kono
parents:
diff changeset
552 first_clone->next_sibling_clone = node->clones;
kono
parents:
diff changeset
553 first_clone->prev_sibling_clone = NULL;
kono
parents:
diff changeset
554 node->clones->prev_sibling_clone = first_clone;
kono
parents:
diff changeset
555 node->clones = first_clone;
kono
parents:
diff changeset
556 }
kono
parents:
diff changeset
557 first_clone->decl = copy_node (node->decl);
kono
parents:
diff changeset
558 first_clone->decl->decl_with_vis.symtab_node = first_clone;
kono
parents:
diff changeset
559 gcc_assert (first_clone == cgraph_node::get (first_clone->decl));
kono
parents:
diff changeset
560
kono
parents:
diff changeset
561 /* Now reshape the clone tree, so all other clones descends from
kono
parents:
diff changeset
562 first_clone. */
kono
parents:
diff changeset
563 if (first_clone->next_sibling_clone)
kono
parents:
diff changeset
564 {
kono
parents:
diff changeset
565 for (n = first_clone->next_sibling_clone; n->next_sibling_clone;
kono
parents:
diff changeset
566 n = n->next_sibling_clone)
kono
parents:
diff changeset
567 n->clone_of = first_clone;
kono
parents:
diff changeset
568 n->clone_of = first_clone;
kono
parents:
diff changeset
569 n->next_sibling_clone = first_clone->clones;
kono
parents:
diff changeset
570 if (first_clone->clones)
kono
parents:
diff changeset
571 first_clone->clones->prev_sibling_clone = n;
kono
parents:
diff changeset
572 first_clone->clones = first_clone->next_sibling_clone;
kono
parents:
diff changeset
573 first_clone->next_sibling_clone->prev_sibling_clone = NULL;
kono
parents:
diff changeset
574 first_clone->next_sibling_clone = NULL;
kono
parents:
diff changeset
575 gcc_assert (!first_clone->prev_sibling_clone);
kono
parents:
diff changeset
576 }
kono
parents:
diff changeset
577 first_clone->clone_of = NULL;
kono
parents:
diff changeset
578
kono
parents:
diff changeset
579 /* Now node in question has no clones. */
kono
parents:
diff changeset
580 node->clones = NULL;
kono
parents:
diff changeset
581
kono
parents:
diff changeset
582 /* Inline clones share decl with the function they are cloned
kono
parents:
diff changeset
583 from. Walk the whole clone tree and redirect them all to the
kono
parents:
diff changeset
584 new decl. */
kono
parents:
diff changeset
585 if (first_clone->clones)
kono
parents:
diff changeset
586 for (n = first_clone->clones; n != first_clone;)
kono
parents:
diff changeset
587 {
kono
parents:
diff changeset
588 gcc_assert (n->decl == node->decl);
kono
parents:
diff changeset
589 n->decl = first_clone->decl;
kono
parents:
diff changeset
590 if (n->clones)
kono
parents:
diff changeset
591 n = n->clones;
kono
parents:
diff changeset
592 else if (n->next_sibling_clone)
kono
parents:
diff changeset
593 n = n->next_sibling_clone;
kono
parents:
diff changeset
594 else
kono
parents:
diff changeset
595 {
kono
parents:
diff changeset
596 while (n != first_clone && !n->next_sibling_clone)
kono
parents:
diff changeset
597 n = n->clone_of;
kono
parents:
diff changeset
598 if (n != first_clone)
kono
parents:
diff changeset
599 n = n->next_sibling_clone;
kono
parents:
diff changeset
600 }
kono
parents:
diff changeset
601 }
kono
parents:
diff changeset
602
kono
parents:
diff changeset
603 /* Copy the OLD_VERSION_NODE function tree to the new version. */
kono
parents:
diff changeset
604 tree_function_versioning (node->decl, first_clone->decl,
kono
parents:
diff changeset
605 NULL, true, NULL, false,
kono
parents:
diff changeset
606 NULL, NULL);
kono
parents:
diff changeset
607
kono
parents:
diff changeset
608 /* The function will be short lived and removed after we inline all the clones,
kono
parents:
diff changeset
609 but make it internal so we won't confuse ourself. */
kono
parents:
diff changeset
610 DECL_EXTERNAL (first_clone->decl) = 0;
kono
parents:
diff changeset
611 TREE_PUBLIC (first_clone->decl) = 0;
kono
parents:
diff changeset
612 DECL_COMDAT (first_clone->decl) = 0;
kono
parents:
diff changeset
613 first_clone->ipa_transforms_to_apply.release ();
kono
parents:
diff changeset
614
kono
parents:
diff changeset
615 /* When doing recursive inlining, the clone may become unnecessary.
kono
parents:
diff changeset
616 This is possible i.e. in the case when the recursive function is proved to be
kono
parents:
diff changeset
617 non-throwing and the recursion happens only in the EH landing pad.
kono
parents:
diff changeset
618 We can not remove the clone until we are done with saving the body.
kono
parents:
diff changeset
619 Remove it now. */
kono
parents:
diff changeset
620 if (!first_clone->callers)
kono
parents:
diff changeset
621 {
kono
parents:
diff changeset
622 first_clone->remove_symbol_and_inline_clones ();
kono
parents:
diff changeset
623 first_clone = NULL;
kono
parents:
diff changeset
624 }
kono
parents:
diff changeset
625 else if (flag_checking)
kono
parents:
diff changeset
626 first_clone->verify ();
kono
parents:
diff changeset
627
kono
parents:
diff changeset
628 return first_clone;
kono
parents:
diff changeset
629 }
kono
parents:
diff changeset
630
kono
parents:
diff changeset
631 /* Return true when function body of DECL still needs to be kept around
kono
parents:
diff changeset
632 for later re-use. */
kono
parents:
diff changeset
633 static bool
kono
parents:
diff changeset
634 preserve_function_body_p (struct cgraph_node *node)
kono
parents:
diff changeset
635 {
kono
parents:
diff changeset
636 gcc_assert (symtab->global_info_ready);
kono
parents:
diff changeset
637 gcc_assert (!node->alias && !node->thunk.thunk_p);
kono
parents:
diff changeset
638
kono
parents:
diff changeset
639 /* Look if there is any non-thunk clone around. */
kono
parents:
diff changeset
640 for (node = node->clones; node; node = node->next_sibling_clone)
kono
parents:
diff changeset
641 if (!node->thunk.thunk_p)
kono
parents:
diff changeset
642 return true;
kono
parents:
diff changeset
643 return false;
kono
parents:
diff changeset
644 }
kono
parents:
diff changeset
645
kono
parents:
diff changeset
646 /* Apply inline plan to function. */
kono
parents:
diff changeset
647
kono
parents:
diff changeset
648 unsigned int
kono
parents:
diff changeset
649 inline_transform (struct cgraph_node *node)
kono
parents:
diff changeset
650 {
kono
parents:
diff changeset
651 unsigned int todo = 0;
kono
parents:
diff changeset
652 struct cgraph_edge *e, *next;
kono
parents:
diff changeset
653 bool has_inline = false;
kono
parents:
diff changeset
654
kono
parents:
diff changeset
655 /* FIXME: Currently the pass manager is adding inline transform more than
kono
parents:
diff changeset
656 once to some clones. This needs revisiting after WPA cleanups. */
kono
parents:
diff changeset
657 if (cfun->after_inlining)
kono
parents:
diff changeset
658 return 0;
kono
parents:
diff changeset
659
kono
parents:
diff changeset
660 /* We might need the body of this function so that we can expand
kono
parents:
diff changeset
661 it inline somewhere else. */
kono
parents:
diff changeset
662 if (preserve_function_body_p (node))
kono
parents:
diff changeset
663 save_inline_function_body (node);
kono
parents:
diff changeset
664
kono
parents:
diff changeset
665 for (e = node->callees; e; e = next)
kono
parents:
diff changeset
666 {
kono
parents:
diff changeset
667 if (!e->inline_failed)
kono
parents:
diff changeset
668 has_inline = true;
kono
parents:
diff changeset
669 next = e->next_callee;
kono
parents:
diff changeset
670 e->redirect_call_stmt_to_callee ();
kono
parents:
diff changeset
671 }
kono
parents:
diff changeset
672 node->remove_all_references ();
kono
parents:
diff changeset
673
kono
parents:
diff changeset
674 timevar_push (TV_INTEGRATION);
kono
parents:
diff changeset
675 if (node->callees && (opt_for_fn (node->decl, optimize) || has_inline))
kono
parents:
diff changeset
676 {
kono
parents:
diff changeset
677 profile_count num = node->count;
kono
parents:
diff changeset
678 profile_count den = ENTRY_BLOCK_PTR_FOR_FN (cfun)->count;
kono
parents:
diff changeset
679 bool scale = num.initialized_p ()
kono
parents:
diff changeset
680 && (den > 0 || num == profile_count::zero ())
kono
parents:
diff changeset
681 && !(num == den);
kono
parents:
diff changeset
682 if (scale)
kono
parents:
diff changeset
683 {
kono
parents:
diff changeset
684 if (dump_file)
kono
parents:
diff changeset
685 {
kono
parents:
diff changeset
686 fprintf (dump_file, "Applying count scale ");
kono
parents:
diff changeset
687 num.dump (dump_file);
kono
parents:
diff changeset
688 fprintf (dump_file, "/");
kono
parents:
diff changeset
689 den.dump (dump_file);
kono
parents:
diff changeset
690 fprintf (dump_file, "\n");
kono
parents:
diff changeset
691 }
kono
parents:
diff changeset
692
kono
parents:
diff changeset
693 basic_block bb;
kono
parents:
diff changeset
694 FOR_ALL_BB_FN (bb, cfun)
kono
parents:
diff changeset
695 bb->count = bb->count.apply_scale (num, den);
kono
parents:
diff changeset
696 ENTRY_BLOCK_PTR_FOR_FN (cfun)->count = node->count;
kono
parents:
diff changeset
697 }
kono
parents:
diff changeset
698 todo = optimize_inline_calls (current_function_decl);
kono
parents:
diff changeset
699 }
kono
parents:
diff changeset
700 timevar_pop (TV_INTEGRATION);
kono
parents:
diff changeset
701
kono
parents:
diff changeset
702 cfun->always_inline_functions_inlined = true;
kono
parents:
diff changeset
703 cfun->after_inlining = true;
kono
parents:
diff changeset
704 todo |= execute_fixup_cfg ();
kono
parents:
diff changeset
705
kono
parents:
diff changeset
706 if (!(todo & TODO_update_ssa_any))
kono
parents:
diff changeset
707 /* Redirecting edges might lead to a need for vops to be recomputed. */
kono
parents:
diff changeset
708 todo |= TODO_update_ssa_only_virtuals;
kono
parents:
diff changeset
709
kono
parents:
diff changeset
710 return todo;
kono
parents:
diff changeset
711 }