annotate gcc/testsuite/ChangeLog.jit @ 118:fd00160c1b76

ifdef TARGET_64BIT
author mir3636
date Tue, 27 Feb 2018 15:01:35 +0900
parents 04ced10e8804
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
111
kono
parents:
diff changeset
1 2014-11-05 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
2
kono
parents:
diff changeset
3 * jit.dg/test-error-get-type-bad-enum.c: New test case.
kono
parents:
diff changeset
4 * jit.dg/test-error-new-binary-op-bad-op.c: Likewise.
kono
parents:
diff changeset
5 * jit.dg/test-error-new-function-bad-kind.c: Likewise.
kono
parents:
diff changeset
6 * jit.dg/test-error-new-unary-op-bad-op.c: Likewise.
kono
parents:
diff changeset
7
kono
parents:
diff changeset
8 2014-10-22 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
9
kono
parents:
diff changeset
10 * jit.dg/jit.exp (DEFAULT_CFLAGS): Add -fgnu89-inline since
kono
parents:
diff changeset
11 dejagnu.h assumes this.
kono
parents:
diff changeset
12
kono
parents:
diff changeset
13 2014-10-17 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
14
kono
parents:
diff changeset
15 * jit.dg/jit.exp (get_path_of_driver): New procedure.
kono
parents:
diff changeset
16 (jit-dg-test): Don't unsetenv GCC_EXEC_PREFIX, since jit-playback.c
kono
parents:
diff changeset
17 now adds -fno-use-linker-plugin to the driver cmdline sidestepping
kono
parents:
diff changeset
18 the builddir/installdir libtto_plugin naming issue.
kono
parents:
diff changeset
19 When setting up PATH so that the JIT library can invoke the driver
kono
parents:
diff changeset
20 by installation name, don't use the installation "bindir".
kono
parents:
diff changeset
21 Instead, simply use the location of xgcc as detected
kono
parents:
diff changeset
22 get_path_of_driver. In addition, set up LIBRARY_PATH so that the
kono
parents:
diff changeset
23 linker run from inside the JIT library can locate libgcc etc when
kono
parents:
diff changeset
24 building the .so, pointing it at the same directory.
kono
parents:
diff changeset
25
kono
parents:
diff changeset
26 2014-10-13 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
27
kono
parents:
diff changeset
28 * jit.dg/jit.exp (fixed_host_execute): New function, taken from
kono
parents:
diff changeset
29 "host_execute" in DejaGnu's dejagnu.exp, with one line removed.
kono
parents:
diff changeset
30 (jit-dg-test): Use fixed_host_execute, rathern than host_execute.
kono
parents:
diff changeset
31
kono
parents:
diff changeset
32 2014-10-13 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
33
kono
parents:
diff changeset
34 * jit.dg/harness.h [MAKE_DEJAGNU_H_THREADSAFE] (note): Redefine
kono
parents:
diff changeset
35 "note" from dejagnu.h to new function dejagnu_note so that we can
kono
parents:
diff changeset
36 make "note" be threadsafe.
kono
parents:
diff changeset
37 (set_options): Don't enable GCC_JIT_BOOL_OPTION_DUMP_SUMMARY,
kono
parents:
diff changeset
38 since it can generate large amounts of output that could overwhelm
kono
parents:
diff changeset
39 expect's buffer.
kono
parents:
diff changeset
40 * jit.dg/test-dot-product.c (verify_code): Use "note" rather than
kono
parents:
diff changeset
41 "printf", to give DejaGnu more chances to parse this log data,
kono
parents:
diff changeset
42 rather than overflowing its buffer.
kono
parents:
diff changeset
43 * jit.dg/test-factorial.c (verify_code): Likewise.
kono
parents:
diff changeset
44 * jit.dg/test-fibonacci.c (verify_code): Likewise.
kono
parents:
diff changeset
45 * jit.dg/test-fuzzer.c (main): Likewise.
kono
parents:
diff changeset
46 * jit.dg/test-nested-loops.c (verify_code): Likewise.
kono
parents:
diff changeset
47 * jit.dg/test-sum-of-squares.c (verify_code): Likewise.
kono
parents:
diff changeset
48 * jit.dg/test-threads.c (note): New function, adding thread-safety
kono
parents:
diff changeset
49 on top of "dejagnu_note", the latter being the implementation
kono
parents:
diff changeset
50 found in dejagnu.h.
kono
parents:
diff changeset
51 (run_threaded_test): Use "note" rather than "printf".
kono
parents:
diff changeset
52
kono
parents:
diff changeset
53 2014-10-07 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
54
kono
parents:
diff changeset
55 * jit.dg/jit.exp (jit-dg-test): Prepend the installed bindir to
kono
parents:
diff changeset
56 the PATH before invoking built binaries using the library, so that
kono
parents:
diff changeset
57 the library can find the driver. Restore the PATH immediately
kono
parents:
diff changeset
58 afterwards.
kono
parents:
diff changeset
59
kono
parents:
diff changeset
60 2014-09-24 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
61
kono
parents:
diff changeset
62 * ChangeLog.jit: Add copyright footer.
kono
parents:
diff changeset
63
kono
parents:
diff changeset
64 2014-09-23 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
65
kono
parents:
diff changeset
66 * jit.dg/test-expressions.c (make_tests_of_binary_ops): Add
kono
parents:
diff changeset
67 shift operators.
kono
parents:
diff changeset
68 (verify_binary_ops): Likewise.
kono
parents:
diff changeset
69
kono
parents:
diff changeset
70 2014-09-18 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
71
kono
parents:
diff changeset
72 * jit.dg/jit.exp: When constructing "tests", add the example files
kono
parents:
diff changeset
73 from the documentation, to ensure that they compile.
kono
parents:
diff changeset
74
kono
parents:
diff changeset
75 2014-09-10 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
76
kono
parents:
diff changeset
77 * jit.dg/jit.exp: Load target-supports.exp.
kono
parents:
diff changeset
78
kono
parents:
diff changeset
79 2014-09-09 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
80
kono
parents:
diff changeset
81 * jit.dg/test-nested-loops.c: New test case.
kono
parents:
diff changeset
82 * jit.dg/all-non-failing-tests.h: Add test-nested-loops.c.
kono
parents:
diff changeset
83 * jit.dg/test-combination.c (create_code): Likewise.
kono
parents:
diff changeset
84 (verify_code): Likewise.
kono
parents:
diff changeset
85 * jit.dg/test-threads.c (const): Add test-nested-loops.c.
kono
parents:
diff changeset
86
kono
parents:
diff changeset
87 2014-08-11 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
88
kono
parents:
diff changeset
89 * jit.dg/test-threads.c: New test case, running all of the
kono
parents:
diff changeset
90 individual test cases in separate threads.
kono
parents:
diff changeset
91 * jit.dg/test-combination.c: Move inclusion of the various
kono
parents:
diff changeset
92 individual testcases into...
kono
parents:
diff changeset
93 * jit.dg/all-non-failing-tests.h: ...this new file, and rename
kono
parents:
diff changeset
94 TEST_COMBINATION to COMBINED_TEST.
kono
parents:
diff changeset
95 * jit.dg/harness.h: Respond to new macro MAKE_DEJAGNU_H_THREADSAFE
kono
parents:
diff changeset
96 by hacking up <dejagnu.h> to be threadsafe. Rename
kono
parents:
diff changeset
97 TEST_COMBINATION to COMBINED_TEST.
kono
parents:
diff changeset
98 * jit.dg/jit.exp (proc jit-dg-test): Add "-lpthread" when building
kono
parents:
diff changeset
99 test-threads.exe.
kono
parents:
diff changeset
100
kono
parents:
diff changeset
101 2014-08-08 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
102
kono
parents:
diff changeset
103 * jit.dg/test-accessing-union.c: New test case.
kono
parents:
diff changeset
104 * jit.dg/test-combination.c: Add test-accessing-union.c.
kono
parents:
diff changeset
105
kono
parents:
diff changeset
106 2014-08-08 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
107
kono
parents:
diff changeset
108 * jit.dg/test-combination.c (create_code): Add missing calls to
kono
parents:
diff changeset
109 create_code_quadratic and create_code_reading_struct.
kono
parents:
diff changeset
110 (verify_code): Add missing calls to verify_code_quadratic and
kono
parents:
diff changeset
111 verify_code_reading_struct.
kono
parents:
diff changeset
112
kono
parents:
diff changeset
113 2014-08-08 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
114
kono
parents:
diff changeset
115 * jit.dg/test-calling-function-ptr.c: New test case.
kono
parents:
diff changeset
116 * jit.dg/test-combination.c: Add test-calling-function-ptr.c.
kono
parents:
diff changeset
117 * jit.dg/test-error-call-through-ptr-with-mismatching-args.c: New
kono
parents:
diff changeset
118 test case.
kono
parents:
diff changeset
119 * jit.dg/test-error-call-through-ptr-with-non-function.c: New test
kono
parents:
diff changeset
120 case.
kono
parents:
diff changeset
121 * jit.dg/test-error-call-through-ptr-with-non-pointer.c: New test
kono
parents:
diff changeset
122 case.
kono
parents:
diff changeset
123 * jit.dg/test-error-call-through-ptr-with-not-enough-args.c: New
kono
parents:
diff changeset
124 test case.
kono
parents:
diff changeset
125
kono
parents:
diff changeset
126 2014-07-25 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
127
kono
parents:
diff changeset
128 * jit.dg/test-error-index-not-a-numeric-type.c: New test case.
kono
parents:
diff changeset
129 * jit.dg/test-error-value-not-a-numeric-type.c: New test case.
kono
parents:
diff changeset
130
kono
parents:
diff changeset
131 2014-03-19 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
132
kono
parents:
diff changeset
133 * jit.dg/test-array-as-pointer.c: New test case, verifying that
kono
parents:
diff changeset
134 there's a way to treat arrays as pointers.
kono
parents:
diff changeset
135 * jit.dg/test-combination.c: Add test-array-as-pointer.c...
kono
parents:
diff changeset
136 (create_code): ...here and...
kono
parents:
diff changeset
137 (verify_code): ...here.
kono
parents:
diff changeset
138
kono
parents:
diff changeset
139 * jit.dg/test-error-array-as-pointer.c: New test case, verifying
kono
parents:
diff changeset
140 that bogus casts from array to pointer are caught by the type
kono
parents:
diff changeset
141 system, rather than leading to ICEs seen in:
kono
parents:
diff changeset
142 https://github.com/davidmalcolm/pygccjit/pull/3#issuecomment-37883129
kono
parents:
diff changeset
143
kono
parents:
diff changeset
144 2014-03-18 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
145
kono
parents:
diff changeset
146 * jit.dg/test-combination.c: Add test-arrays.c and test-volatile.c.
kono
parents:
diff changeset
147 Add comment about test-error-*.c. Remove comment about
kono
parents:
diff changeset
148 test-failure.c, which was removed in
kono
parents:
diff changeset
149 96b218c9a1d5f39fb649e02c0e77586b180e8516.
kono
parents:
diff changeset
150 (create_code): Call into test-arrays.c and test-volatile.c.
kono
parents:
diff changeset
151 (verify_code): Likewise.
kono
parents:
diff changeset
152
kono
parents:
diff changeset
153 2014-03-14 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
154
kono
parents:
diff changeset
155 * jit.dg/test-expressions.c (called_pointer_checking_function): New.
kono
parents:
diff changeset
156 (make_tests_of_casts): Add test of casting from array to pointer.
kono
parents:
diff changeset
157 (verify_casts): Likewise.
kono
parents:
diff changeset
158
kono
parents:
diff changeset
159 2014-03-13 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
160
kono
parents:
diff changeset
161 * jit.dg/test-error-bad-cast.c: New test case.
kono
parents:
diff changeset
162
kono
parents:
diff changeset
163 2014-03-11 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
164
kono
parents:
diff changeset
165 * jit.dg/harness.h (set_options): Increase optimization level from
kono
parents:
diff changeset
166 0 to 3.
kono
parents:
diff changeset
167
kono
parents:
diff changeset
168 2014-03-07 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
169
kono
parents:
diff changeset
170 * jit.dg/test-functions.c (create_test_of_hidden_function): New,
kono
parents:
diff changeset
171 adding test coverage for GCC_JIT_FUNCTION_ALWAYS_INLINE and
kono
parents:
diff changeset
172 GCC_JIT_FUNCTION_INTERNAL.
kono
parents:
diff changeset
173 (create_tests_of_hidden_functions): Likewise.
kono
parents:
diff changeset
174 (verify_hidden_functions): Likewise.
kono
parents:
diff changeset
175 (create_code): Add call to create_tests_of_hidden_functions.
kono
parents:
diff changeset
176 (verify_code): Add call to verify_hidden_functions.
kono
parents:
diff changeset
177 * jit.dg/test-quadratic.c (make_calc_discriminant): Convert
kono
parents:
diff changeset
178 from GCC_JIT_FUNCTION_EXPORTED to GCC_JIT_FUNCTION_INTERNAL.
kono
parents:
diff changeset
179
kono
parents:
diff changeset
180 2014-03-07 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
181
kono
parents:
diff changeset
182 * jit.dg/test-functions.c: Reorder function definitions, grouping
kono
parents:
diff changeset
183 them by subject-matter rather than by create-vs-verify phase.
kono
parents:
diff changeset
184
kono
parents:
diff changeset
185 2014-03-06 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
186
kono
parents:
diff changeset
187 * jit.dg/test-nested-contexts.c (main): Dump the contexts to
kono
parents:
diff changeset
188 files, setting up source locations, and adding test coverage for
kono
parents:
diff changeset
189 gcc_jit_context_dump_to_file.
kono
parents:
diff changeset
190
kono
parents:
diff changeset
191 2014-03-04 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
192
kono
parents:
diff changeset
193 * jit.dg/test-error-mismatching-types-in-call.c: New test case,
kono
parents:
diff changeset
194 to ensure that a (struct foo *) vs (struct foo) type error is
kono
parents:
diff changeset
195 gracefully handled.
kono
parents:
diff changeset
196
kono
parents:
diff changeset
197 2014-03-04 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
198
kono
parents:
diff changeset
199 * jit.dg/test-volatile.c: New testcase, to exercise
kono
parents:
diff changeset
200 gcc_jit_type_get_volatile, and show a way to work with pre-existing
kono
parents:
diff changeset
201 global variables.
kono
parents:
diff changeset
202
kono
parents:
diff changeset
203 2014-02-28 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
204
kono
parents:
diff changeset
205 * jit.dg/test-expressions.c (make_test_of_cast): New, to test new
kono
parents:
diff changeset
206 entrypoint gcc_jit_context_new_cast.
kono
parents:
diff changeset
207 (make_tests_of_casts): New.
kono
parents:
diff changeset
208 (create_code): Add call to make_tests_of_casts.
kono
parents:
diff changeset
209 (verify_code): Add call to verify_casts.
kono
parents:
diff changeset
210
kono
parents:
diff changeset
211 2014-02-27 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
212
kono
parents:
diff changeset
213 * jit.dg/test-accessing-struct.c (create_code): Port to
kono
parents:
diff changeset
214 block-based API.
kono
parents:
diff changeset
215 * jit.dg/test-calling-external-function.c (create_code): Likewise.
kono
parents:
diff changeset
216 * jit.dg/test-error-accessing-field-in-other-struct.c (create_code):
kono
parents:
diff changeset
217 Likewise.
kono
parents:
diff changeset
218 * jit.dg/test-error-call-with-mismatching-args.c (create_code):
kono
parents:
diff changeset
219 Likewise.
kono
parents:
diff changeset
220 * jit.dg/test-error-call-with-not-enough-args.c (create_code):
kono
parents:
diff changeset
221 Likewise.
kono
parents:
diff changeset
222 * jit.dg/test-error-call-with-too-many-args.c (create_code):
kono
parents:
diff changeset
223 Likewise.
kono
parents:
diff changeset
224 * jit.dg/test-error-dereference-field-of-non-pointer.c (create_code):
kono
parents:
diff changeset
225 Likewise.
kono
parents:
diff changeset
226 * jit.dg/test-error-dereference-read: Likewise.
kono
parents:
diff changeset
227 * jit.dg/test-error-mismatching-types-in-assignment.c: Likewise.
kono
parents:
diff changeset
228 * jit.dg/test-error-return-within-void-function.c: Likewise.
kono
parents:
diff changeset
229 * jit.dg/test-expressions.c: Likewise.
kono
parents:
diff changeset
230 * jit.dg/test-factorial.c: Likewise.
kono
parents:
diff changeset
231 * jit.dg/test-functions.c: Likewise.
kono
parents:
diff changeset
232 * jit.dg/test-fuzzer.c: Likewise.
kono
parents:
diff changeset
233 * jit.dg/test-hello-world.c (create_code): Likewise.
kono
parents:
diff changeset
234 * jit.dg/test-nested-contexts.c: Likewise.
kono
parents:
diff changeset
235 * jit.dg/test-operator-overloading.cc: Likewise.
kono
parents:
diff changeset
236 * jit.dg/test-quadratic.c: Likewise.
kono
parents:
diff changeset
237 * jit.dg/test-quadratic.cc: Likewise.
kono
parents:
diff changeset
238 * jit.dg/test-reading-struct.c (create_code): Likewise.
kono
parents:
diff changeset
239 * jit.dg/test-string-literal.c (create_code): Likewise.
kono
parents:
diff changeset
240 * jit.dg/test-sum-of-squares.c (create_code): Likewise.
kono
parents:
diff changeset
241 * jit.dg/test-types.c (create_code): Likewise.
kono
parents:
diff changeset
242 * jit.dg/test-using-global.c (create_code): Likewise.
kono
parents:
diff changeset
243
kono
parents:
diff changeset
244 * jit.dg/test-arrays.c (create_code): Likewise, eliminating use of
kono
parents:
diff changeset
245 loop API.
kono
parents:
diff changeset
246 * jit.dg/test-dot-product.c (create_code): Likewise.
kono
parents:
diff changeset
247 * jit.dg/test-linked-list.c (create_code): Likewise.
kono
parents:
diff changeset
248
kono
parents:
diff changeset
249 * jit.dg/test-error-adding-to-terminated-block.c: New testcase.
kono
parents:
diff changeset
250 * jit.dg/test-error-block-in-wrong-function.c: Likewise.
kono
parents:
diff changeset
251 * jit.dg/test-error-missing-return.c: Likewise.
kono
parents:
diff changeset
252 * jit.dg/test-error-unreachable-block.c: Likewise.
kono
parents:
diff changeset
253 * jit.dg/test-error-unterminated-block.c: Likewise.
kono
parents:
diff changeset
254
kono
parents:
diff changeset
255 * jit.dg/test-error-label-already-placed.c: Delete obsolete testcase.
kono
parents:
diff changeset
256 * jit.dg/test-error-unplaced-label.c: Likewise.
kono
parents:
diff changeset
257
kono
parents:
diff changeset
258 2014-02-25 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
259
kono
parents:
diff changeset
260 * jit.dg/test-functions.c (create_use_of_void_return): New, to add
kono
parents:
diff changeset
261 test coverage for gcc_jit_function_add_void_return.
kono
parents:
diff changeset
262 (verify_void_return): Likewise.
kono
parents:
diff changeset
263 (create_code): Add call to create_use_of_void_return.
kono
parents:
diff changeset
264 (verify_code): Add call to verify_void_return.
kono
parents:
diff changeset
265
kono
parents:
diff changeset
266 2014-02-18 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
267
kono
parents:
diff changeset
268 * jit.dg/test-accessing-struct.c (create_code): Update for change to
kono
parents:
diff changeset
269 return type of gcc_jit_context_new_struct_type.
kono
parents:
diff changeset
270 * jit.dg/test-arrays.c (create_code): Likewise.
kono
parents:
diff changeset
271 * jit.dg/test-error-accessing-field-in-other-struct.c (create_code):
kono
parents:
diff changeset
272 Likewise.
kono
parents:
diff changeset
273 * jit.dg/test-error-dereference-field-of-non-pointer.c (create_code):
kono
parents:
diff changeset
274 Likewise.
kono
parents:
diff changeset
275 * jit.dg/test-fuzzer.c (make_random_type): Likewise.
kono
parents:
diff changeset
276 * jit.dg/test-nested-contexts.c (make_types): Likewise.
kono
parents:
diff changeset
277 * jit.dg/test-quadratic.c (make_types): Likewise.
kono
parents:
diff changeset
278 * jit.dg/test-reading-struct.c (create_code): Likewise.
kono
parents:
diff changeset
279 * jit.dg/test-types.c (create_code): Likewise.
kono
parents:
diff changeset
280
kono
parents:
diff changeset
281 * jit.dg/test-linked-list.c: New selftest, exercising
kono
parents:
diff changeset
282 gcc_jit_context_new_opaque_struct, gcc_jit_type_get_pointer, and
kono
parents:
diff changeset
283 gcc_jit_context_null.
kono
parents:
diff changeset
284 * jit.dg/test-combination.c: Add test-linked-list.c
kono
parents:
diff changeset
285
kono
parents:
diff changeset
286 2014-02-14 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
287
kono
parents:
diff changeset
288 * jit.dg/test-operator-overloading.cc (make_test_quadratic): Use
kono
parents:
diff changeset
289 the new "zero" and "one" methods of gccjit::type.
kono
parents:
diff changeset
290 * jit.dg/test-quadratic.cc (make_test_quadratic): Use the new
kono
parents:
diff changeset
291 "add_call" method of gccjit::function.
kono
parents:
diff changeset
292
kono
parents:
diff changeset
293 2014-02-13 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
294
kono
parents:
diff changeset
295 * jit.dg/harness.h (CHECK_DOUBLE_VALUE): New macro.
kono
parents:
diff changeset
296 (CHECK): New macro.
kono
parents:
diff changeset
297 * jit.dg/test-functions.c: New testcase, exercising
kono
parents:
diff changeset
298 gcc_jit_context_get_builtin_function.
kono
parents:
diff changeset
299 * jit.dg/test-combination.c: Add test-functions.c to the combined
kono
parents:
diff changeset
300 test.
kono
parents:
diff changeset
301
kono
parents:
diff changeset
302 2014-02-11 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
303
kono
parents:
diff changeset
304 * jit.dg/test-types.c: Add test coverage for getting type
kono
parents:
diff changeset
305 GCC_JIT_TYPE_BOOL.
kono
parents:
diff changeset
306 * jit.dg/test-expressions.c (make_test_of_comparison): Convert
kono
parents:
diff changeset
307 return type from int to bool.
kono
parents:
diff changeset
308 (verify_comparisons): Likewise.
kono
parents:
diff changeset
309
kono
parents:
diff changeset
310 2014-02-11 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
311
kono
parents:
diff changeset
312 * jit.dg/test-error-unplaced-label.c (verify_code): Update
kono
parents:
diff changeset
313 expected error message to reflect commit
kono
parents:
diff changeset
314 6cd4f82c5237cc328aea229cdaaa428ff09d6e98.
kono
parents:
diff changeset
315
kono
parents:
diff changeset
316 2014-02-10 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
317
kono
parents:
diff changeset
318 * jit.dg/test-types.c (struct zoo): Add field m_sized_int_type,
kono
parents:
diff changeset
319 to be populated by...
kono
parents:
diff changeset
320 (create_code): Use gcc_jit_context_get_int_type.
kono
parents:
diff changeset
321 (verify_code): Verify that type from gcc_jit_context_get_int_type
kono
parents:
diff changeset
322 works properly.
kono
parents:
diff changeset
323 * jit.dg/test-operator-overloading.cc (make_types): Use the
kono
parents:
diff changeset
324 template form of get_int_type.
kono
parents:
diff changeset
325 * jit.dg/test-quadratic.cc (make_types): Likewise.
kono
parents:
diff changeset
326
kono
parents:
diff changeset
327 2014-02-10 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
328
kono
parents:
diff changeset
329 * jit.dg/test-operator-overloading.cc: New testcase, a
kono
parents:
diff changeset
330 rewrite of test-quadratic.cc to use operator overloading.
kono
parents:
diff changeset
331
kono
parents:
diff changeset
332 2014-02-10 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
333
kono
parents:
diff changeset
334 * jit.dg/test-quadratic.cc (make_calc_discriminant): Make use of
kono
parents:
diff changeset
335 new methods of the C++ wrapper API to shorten the example code.
kono
parents:
diff changeset
336 (make_test_quadratic): Likewise.
kono
parents:
diff changeset
337
kono
parents:
diff changeset
338 2014-02-10 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
339
kono
parents:
diff changeset
340 * jit.dg/test-quadratic.cc (make_test_quadratic): Update for
kono
parents:
diff changeset
341 change to gccjit::context::new_call to pass args by reference
kono
parents:
diff changeset
342 rather than by value.
kono
parents:
diff changeset
343
kono
parents:
diff changeset
344 2014-02-03 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
345
kono
parents:
diff changeset
346 * jit.dg/harness.h (check_string_value): Add a forward declaration,
kono
parents:
diff changeset
347 so that we can use CHECK_STRING_VALUE from within tests used by
kono
parents:
diff changeset
348 test-combination.c.
kono
parents:
diff changeset
349
kono
parents:
diff changeset
350 * jit.dg/test-expressions.c (make_test_of_unary_op): Return a debug
kono
parents:
diff changeset
351 stringification of the operation so that it be sanity-checked.
kono
parents:
diff changeset
352 (make_test_of_binary_op): Likewise.
kono
parents:
diff changeset
353 (make_test_of_comparison): Likewise.
kono
parents:
diff changeset
354 (make_tests_of_unary_ops): Verify that said stringifications are
kono
parents:
diff changeset
355 indeed sane.
kono
parents:
diff changeset
356 (make_tests_of_binary_ops): Likewise.
kono
parents:
diff changeset
357 (make_tests_of_comparisons): Likewise.
kono
parents:
diff changeset
358
kono
parents:
diff changeset
359 * jit.dg/test-quadratic.cc (make_types): Verify that the
kono
parents:
diff changeset
360 get_debug_string method works.
kono
parents:
diff changeset
361 (make_test_quadratic): Likewise, also, verify that the <<
kono
parents:
diff changeset
362 operator works.
kono
parents:
diff changeset
363
kono
parents:
diff changeset
364 2014-01-31 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
365
kono
parents:
diff changeset
366 * jit.dg/test-quadratic.cc: New file - a translation of
kono
parents:
diff changeset
367 test-quadratic.c to the libgccjit++.h C++ API.
kono
parents:
diff changeset
368
kono
parents:
diff changeset
369 2014-01-30 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
370
kono
parents:
diff changeset
371 * jit.dg/test-error-label-already-placed.c: New test case.
kono
parents:
diff changeset
372 * jit.dg/test-error-unplaced-label.c: New test case.
kono
parents:
diff changeset
373
kono
parents:
diff changeset
374 2014-01-30 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
375
kono
parents:
diff changeset
376 * jit.dg/test-error-call-with-mismatching-args.c: New test case.
kono
parents:
diff changeset
377
kono
parents:
diff changeset
378 2014-01-30 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
379
kono
parents:
diff changeset
380 * jit.dg/test-error-accessing-field-in-other-struct.c: New test
kono
parents:
diff changeset
381 case.
kono
parents:
diff changeset
382 * jit.dg/test-error-dereference-field-of-non-pointer.c: Likewise.
kono
parents:
diff changeset
383 * jit.dg/test-error-dereference-read-of-non-pointer.c: Likewise.
kono
parents:
diff changeset
384 * jit.dg/test-error-mismatching-types-in-assignment.c: Likewise.
kono
parents:
diff changeset
385 * jit.dg/test-error-return-within-void-function.c: Likewise.
kono
parents:
diff changeset
386
kono
parents:
diff changeset
387 2014-01-29 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
388
kono
parents:
diff changeset
389 * jit.dg/test-accessing-struct.c (create_code): Update for API change
kono
parents:
diff changeset
390 for accessing fields in terms of gcc_jit_field pointers rather than
kono
parents:
diff changeset
391 by name.
kono
parents:
diff changeset
392 * jit.dg/test-nested-contexts.c (make_calc_discriminant): Likewise.
kono
parents:
diff changeset
393 (make_test_quadratic): Likewise.
kono
parents:
diff changeset
394 * jit.dg/test-quadratic.c (make_calc_discriminant): Likewise.
kono
parents:
diff changeset
395 (make_test_quadratic): Likewise.
kono
parents:
diff changeset
396 * jit.dg/test-reading-struct.c (create_code): Likewise.
kono
parents:
diff changeset
397 * jit.dg/test-types.c: Likewise.
kono
parents:
diff changeset
398
kono
parents:
diff changeset
399 2014-01-28 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
400
kono
parents:
diff changeset
401 * jit.dg/harness.h (test_jit): Add the possibility of turning off
kono
parents:
diff changeset
402 this function, if the newly-coined "TEST_ESCHEWS_TEST_JIT" is
kono
parents:
diff changeset
403 defined, for use by...
kono
parents:
diff changeset
404 * jit.dg/test-nested-contexts.c: New test case, adapting
kono
parents:
diff changeset
405 test-quadratic.c, but splitting it into a 3-deep arrangement of
kono
parents:
diff changeset
406 nested contexts, to test the implementation of child contexts.
kono
parents:
diff changeset
407
kono
parents:
diff changeset
408 2014-01-28 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
409
kono
parents:
diff changeset
410 * jit.dg/harness.h (test_jit): Move the various calls to set up
kono
parents:
diff changeset
411 options on the context into...
kono
parents:
diff changeset
412 (set_options): ...this new function.
kono
parents:
diff changeset
413
kono
parents:
diff changeset
414 2014-01-27 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
415
kono
parents:
diff changeset
416 * jit.dg/test-error-call-with-not-enough-args.c: New test case.
kono
parents:
diff changeset
417 * jit.dg/test-error-call-with-too-many-args.c: New test case.
kono
parents:
diff changeset
418 * jit.dg/test-null-passed-to-api.c: Rename to...
kono
parents:
diff changeset
419 * jit.dg/test-error-null-passed-to-api.c: ...this, so that
kono
parents:
diff changeset
420 error-handling test cases are consistently named.
kono
parents:
diff changeset
421
kono
parents:
diff changeset
422 2014-01-24 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
423
kono
parents:
diff changeset
424 * jit.dg/test-empty.c: New test case.
kono
parents:
diff changeset
425
kono
parents:
diff changeset
426 2014-01-24 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
427
kono
parents:
diff changeset
428 * jit.dg/harness.h (code_making_callback): Rename to...
kono
parents:
diff changeset
429 (create_code): ...this, and eliminate the returned
kono
parents:
diff changeset
430 error-handling value: test cases will simply call into the
kono
parents:
diff changeset
431 gcc_jit_ API, without needing to be run from a callback.
kono
parents:
diff changeset
432 (test_jit): Don't register a callback, simply call the
kono
parents:
diff changeset
433 "create_code" function for the testcase before compiling the
kono
parents:
diff changeset
434 context.
kono
parents:
diff changeset
435
kono
parents:
diff changeset
436 * jit.dg/test-accessing-struct.c: Rename "code_making_callback"
kono
parents:
diff changeset
437 to "create_code" and eliminate the return code.
kono
parents:
diff changeset
438 * jit.dg/test-calling-external-function.c: Likewise.
kono
parents:
diff changeset
439 * jit.dg/test-combination.c: Likewise.
kono
parents:
diff changeset
440 * jit.dg/test-dot-product.c: Likewise.
kono
parents:
diff changeset
441 * jit.dg/test-expressions.c: Likewise.
kono
parents:
diff changeset
442 * jit.dg/test-factorial.c: Likewise.
kono
parents:
diff changeset
443 * jit.dg/test-fibonacci.c: Likewise.
kono
parents:
diff changeset
444 * jit.dg/test-fuzzer.c: Likewise.
kono
parents:
diff changeset
445 * jit.dg/test-hello-world.c: Likewise.
kono
parents:
diff changeset
446 * jit.dg/test-null-passed-to-api.c: Likewise.
kono
parents:
diff changeset
447 * jit.dg/test-quadratic.c: Likewise.
kono
parents:
diff changeset
448 * jit.dg/test-reading-struct.c: Likewise.
kono
parents:
diff changeset
449 * jit.dg/test-string-literal.c: Likewise.
kono
parents:
diff changeset
450 * jit.dg/test-sum-of-squares.c: Likewise.
kono
parents:
diff changeset
451 * jit.dg/test-types.c: Likewise.
kono
parents:
diff changeset
452 * jit.dg/test-using-global.c: Likewise.
kono
parents:
diff changeset
453
kono
parents:
diff changeset
454 * jit.dg/test-failure.c: Remove this test case, since it was
kono
parents:
diff changeset
455 specifically for testing the now-defunct callback-based API.
kono
parents:
diff changeset
456
kono
parents:
diff changeset
457 2014-01-23 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
458
kono
parents:
diff changeset
459 * jit.dg/test-quadratic.c: New test case, written to achieve test
kono
parents:
diff changeset
460 coverage of gcc_jit_rvalue_access_field, but also exercising
kono
parents:
diff changeset
461 division of doubles.
kono
parents:
diff changeset
462
kono
parents:
diff changeset
463 * jit.dg/test-combination.c: Add test-quadratic.c
kono
parents:
diff changeset
464
kono
parents:
diff changeset
465 * jit.dg/test-expressions.c: Add TODOs.
kono
parents:
diff changeset
466
kono
parents:
diff changeset
467 2014-01-23 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
468
kono
parents:
diff changeset
469 * jit.dg/test-reading-struct.c: New test, to provide test coverage
kono
parents:
diff changeset
470 of gcc_jit_type_get_const and gcc_jit_lvalue_access_field, in the
kono
parents:
diff changeset
471 process uncovering bugs in how locals were handled.
kono
parents:
diff changeset
472 * jit.dg/test-combination.c: Add usage of test-reading-struct.c.
kono
parents:
diff changeset
473
kono
parents:
diff changeset
474 2014-01-21 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
475
kono
parents:
diff changeset
476 * jit.dg/test-hello-world.c (code_making_callback): Add usage of
kono
parents:
diff changeset
477 gcc_jit_function_add_comment.
kono
parents:
diff changeset
478
kono
parents:
diff changeset
479 2013-10-24 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
480
kono
parents:
diff changeset
481 * jit.dg/harness.h (main): Wrap with #ifndef TEST_PROVIDES_MAIN
kono
parents:
diff changeset
482 * jit.dg/test-fuzzer.c: New.
kono
parents:
diff changeset
483
kono
parents:
diff changeset
484 2013-10-22 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
485
kono
parents:
diff changeset
486 * jit.dg/harness.h (verify_code): Add context param so that
kono
parents:
diff changeset
487 test cases of failure can query errors on it.
kono
parents:
diff changeset
488 (CHECK_STRING_VALUE): New.
kono
parents:
diff changeset
489 (check_string_value): New.
kono
parents:
diff changeset
490 (test_jit): Add user_data param and pass it to the code factory.
kono
parents:
diff changeset
491 Pass context to verify_code, calling it before releasing said
kono
parents:
diff changeset
492 context.
kono
parents:
diff changeset
493 (main): Add NULL user_data to test_jit call.
kono
parents:
diff changeset
494 * jit.dg/test-accessing-struct.c (verify_code): Add context
kono
parents:
diff changeset
495 param.
kono
parents:
diff changeset
496 * jit.dg/test-calling-external-function.c (verify_code):
kono
parents:
diff changeset
497 Likewise.
kono
parents:
diff changeset
498 * jit.dg/test-combination.c (verify_code): Likewise.
kono
parents:
diff changeset
499 * jit.dg/test-dot-product.c (verify_code): Likewise.
kono
parents:
diff changeset
500 * jit.dg/test-expressions.c (verify_code): Likewise.
kono
parents:
diff changeset
501 * jit.dg/test-factorial.c (verify_code): Likewise.
kono
parents:
diff changeset
502 * jit.dg/test-failure.c (verify_code): Likewise.
kono
parents:
diff changeset
503 * jit.dg/test-fibonacci.c (verify_code): Likewise.
kono
parents:
diff changeset
504 * jit.dg/test-hello-world.c (verify_code): Likewise.
kono
parents:
diff changeset
505 * jit.dg/test-string-literal.c (verify_code): Likewise.
kono
parents:
diff changeset
506 * jit.dg/test-sum-of-squares.c (verify_code): Likewise.
kono
parents:
diff changeset
507 * jit.dg/test-types.c (verify_code): Likewise.
kono
parents:
diff changeset
508 * jit.dg/test-using-global.c (verify_code): Likewise.
kono
parents:
diff changeset
509 * jit.dg/test-null-passed-to-api.c (verify_code): Likewise;
kono
parents:
diff changeset
510 use context to verify that the library provides a sane error
kono
parents:
diff changeset
511 message to the client code.
kono
parents:
diff changeset
512
kono
parents:
diff changeset
513 2013-10-21 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
514
kono
parents:
diff changeset
515 * jit.dg/test-expressions.c (test_global): New.
kono
parents:
diff changeset
516 (make_test_of_get_address): New.
kono
parents:
diff changeset
517 (verify_get_address): New.
kono
parents:
diff changeset
518 (code_making_callback): Add call to make_test_of_get_address.
kono
parents:
diff changeset
519 (verify_code): Add call to verify_get_address.
kono
parents:
diff changeset
520
kono
parents:
diff changeset
521 2013-10-18 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
522
kono
parents:
diff changeset
523 * jit.dg/test-expressions.c: New.
kono
parents:
diff changeset
524 * jit.dg/test-combination.c: Add usage of test-expressions.c
kono
parents:
diff changeset
525 * jit.dg/test-accessing-struct.c (code_making_callback): Update
kono
parents:
diff changeset
526 for changes to field-access API.
kono
parents:
diff changeset
527 * jit.dg/test-types.c (code_making_callback): Likewise.
kono
parents:
diff changeset
528
kono
parents:
diff changeset
529 2013-10-18 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
530
kono
parents:
diff changeset
531 * jit.dg/test-null-passed-to-api.c: New.
kono
parents:
diff changeset
532
kono
parents:
diff changeset
533 2013-10-17 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
534
kono
parents:
diff changeset
535 * jit.dg/test-accessing-struct.c (code_making_callback): Update
kono
parents:
diff changeset
536 for changes to type API.
kono
parents:
diff changeset
537 * jit.dg/test-calling-external-function.c (code_making_callback):
kono
parents:
diff changeset
538 Likewise.
kono
parents:
diff changeset
539 * jit.dg/test-dot-product.c (code_making_callback): Likewise.
kono
parents:
diff changeset
540 * jit.dg/test-factorial.c (code_making_callback): Likewise.
kono
parents:
diff changeset
541 * jit.dg/test-fibonacci.c (code_making_callback): Likewise.
kono
parents:
diff changeset
542 * jit.dg/test-hello-world.c (code_making_callback): Likewise.
kono
parents:
diff changeset
543 * jit.dg/test-string-literal.c (code_making_callback): Likewise.
kono
parents:
diff changeset
544 * jit.dg/test-sum-of-squares.c (code_making_callback): Likewise.
kono
parents:
diff changeset
545 * jit.dg/test-using-globals.c (code_making_callback): Likewise.
kono
parents:
diff changeset
546 * jit.dg/test-types.c: New.
kono
parents:
diff changeset
547 * jit.dg/test-combination.c (code_making_callback): Use code
kono
parents:
diff changeset
548 from test-types.c.
kono
parents:
diff changeset
549 (verify_code): ...and verify it.
kono
parents:
diff changeset
550
kono
parents:
diff changeset
551 2013-10-16 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
552
kono
parents:
diff changeset
553 * jit.dg/test-dot-product.c (code_making_callback): Update for
kono
parents:
diff changeset
554 API changes to locals.
kono
parents:
diff changeset
555 * jit.dg/test-sum-of-squares.c (code_making_callback): Likewise.
kono
parents:
diff changeset
556
kono
parents:
diff changeset
557 2013-10-14 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
558
kono
parents:
diff changeset
559 * jit.dg/jit.exp (jit-dg-test): Detect compilation errors and
kono
parents:
diff changeset
560 make them be test failures.
kono
parents:
diff changeset
561
kono
parents:
diff changeset
562 2013-10-14 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
563
kono
parents:
diff changeset
564 * jit.dg/test-factorial.c (code_making_callback): Update
kono
parents:
diff changeset
565 for change to gcc_jit_function_place_forward_label.
kono
parents:
diff changeset
566 * jit.dg/test-fibonacci.c (code_making_callback): Add line
kono
parents:
diff changeset
567 numbering to comment, and set up source locations throughout)
kono
parents:
diff changeset
568 allowing stepping throught the comment in the debugger.
kono
parents:
diff changeset
569 * jit.dg/test-sum-of-squares.c (code_making_callback): Update
kono
parents:
diff changeset
570 for change to gcc_jit_function_place_forward_label.
kono
parents:
diff changeset
571
kono
parents:
diff changeset
572 2013-10-10 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
573
kono
parents:
diff changeset
574 * jit.dg/harness.h: Set GCC_JIT_BOOL_OPTION_DUMP_SUMMARY when
kono
parents:
diff changeset
575 running selftests.
kono
parents:
diff changeset
576
kono
parents:
diff changeset
577 2013-10-08 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
578
kono
parents:
diff changeset
579 * jit.dg/harness.h: Wrap parts of harness within a
kono
parents:
diff changeset
580 #ifndef TEST_COMBINATION so that it can be included multiple
kono
parents:
diff changeset
581 times.
kono
parents:
diff changeset
582 * jit.dg/test-accessing-struct.c (code_making_callback): Rename
kono
parents:
diff changeset
583 the generated function from test_fn to test_access to avoid a
kono
parents:
diff changeset
584 naming collision in the combined test.
kono
parents:
diff changeset
585 (verify_code): Likewise.
kono
parents:
diff changeset
586 * jit.dg/test-calling-external-function.c (code_making_callback):
kono
parents:
diff changeset
587 Rename the generated function from test_fn to test_caller.
kono
parents:
diff changeset
588 (verify_code): Likewise.
kono
parents:
diff changeset
589 * jit.dg/test-combination.c: New.
kono
parents:
diff changeset
590 * jit.dg/test-string-literal.c (code_making_callback): Rename
kono
parents:
diff changeset
591 the generated function from test_fn to test_string_literal.
kono
parents:
diff changeset
592 (verify_code): Likewise.
kono
parents:
diff changeset
593 * jit.dg/test-using-global.c (code_making_callback): Rename
kono
parents:
diff changeset
594 the generated function from test_fn to test_using_global.
kono
parents:
diff changeset
595 (verify_code): Likewise.
kono
parents:
diff changeset
596
kono
parents:
diff changeset
597 2013-10-07 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
598
kono
parents:
diff changeset
599 * jit.dg/harness.h (test_jit): Set
kono
parents:
diff changeset
600 GCC_JIT_BOOL_OPTION_SELFCHECK_GC when running selftests.
kono
parents:
diff changeset
601
kono
parents:
diff changeset
602 2013-10-04 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
603
kono
parents:
diff changeset
604 * jit.dg/test-using-global.c: New.
kono
parents:
diff changeset
605
kono
parents:
diff changeset
606 2013-10-03 David Malcolm <dmalcolm@redhat.com>
kono
parents:
diff changeset
607
kono
parents:
diff changeset
608 * jit.dg: New subdirectory
kono
parents:
diff changeset
609 * jit.dg/harness.h: New.
kono
parents:
diff changeset
610 * jit.dg/jit.exp: New.
kono
parents:
diff changeset
611 * jit.dg/test-accessing-struct.c: New.
kono
parents:
diff changeset
612 * jit.dg/test-calling-external-function.c: New.
kono
parents:
diff changeset
613 * jit.dg/test-dot-product.c: New.
kono
parents:
diff changeset
614 * jit.dg/test-factorial.c: New.
kono
parents:
diff changeset
615 * jit.dg/test-failure.c: New.
kono
parents:
diff changeset
616 * jit.dg/test-fibonacci.c: New.
kono
parents:
diff changeset
617 * jit.dg/test-hello-world.c: New.
kono
parents:
diff changeset
618 * jit.dg/test-string-literal.c: New.
kono
parents:
diff changeset
619 * jit.dg/test-sum-of-squares.c: New.
kono
parents:
diff changeset
620
kono
parents:
diff changeset
621
kono
parents:
diff changeset
622 Copyright (C) 2013-2014 Free Software Foundation, Inc.
kono
parents:
diff changeset
623
kono
parents:
diff changeset
624 Copying and distribution of this file, with or without modification,
kono
parents:
diff changeset
625 are permitted in any medium without royalty provided the copyright
kono
parents:
diff changeset
626 notice and this notice are preserved.