Mercurial > hg > Members > kono > jpf-core
view src/main/gov/nasa/jpf/jvm/JVMSystemClassLoaderInfo.java @ 24:6774e2e08d37
the fix I would have liked to avoid - apparently hotspot internally does nested locking during class init, which can lead to deadlocks such as described in http://ternarysearch.blogspot.ru/2013/07/static-initialization-deadlock.html. Actually, it's not a regular deadlock since core dumps still list the threads as runnable, althouth it doesn't seem to be a livelock either. In any case, it can be simulated by nested locking and clinit execution, and it is such a serious defect that we want to be able to catch it. The general mechanism is to replace the disparate (but properly ordered) direct clinit calls of the generic ClassInfo.initializeClass() with a single sythetic method that includes all required locking (bottom up), clinit calls / class status change (top down), and unlocking (top down). We also need to add a synthetic insn to defer changing the class status of classes that don't have clinits(), or otherwise the correct lock/unlock order will not amount to anything if the hierarchy is entered through one of the clinit-absent classes. Now we get proper deadlocks if there are concurrent cyclic dependencies during class resolution. However, this can be such a state exploder that we certainly don't want this as the default behavior, especially since it probably is hotspot specific. Nested class init locking is therefore controlled by jvm.nested_init and respective jvm.nested_init.include/exclude options. Added a NestedInitTest to demonstrate use. Thanks to Lilia Abdulina for bringing this long forgotten issue up
In the wake of nested locks, there were a number of cases to fix that implicitly relied on absent clinits because clients were not properly checking for re-execution (most notably java.util.Exchanger). This mostly came in through MJIEnv.newObject/ElementInfo. We might turn ClinitRequired into a handled exception at some point, to catch such cases during compilation.
Added a UnknownJPFClass exception (in analogy to ClinitRequired), to make clients aware of failed class load attempts/reasons.
fixed Exchanger peer, which was not giving up the lock when timing out. This is an example of a lockfree wait op that can time out. Basically, ThreadInfo.isWaiting() needs to be complemented by a isWaitingOrTimedOut(), and ElementInfo.notifies0() has to be aware of it
fixed NPE when setting report.probe_interval in tests, which was missing that it had to create a stat object
author | Peter Mehlitz <Peter.C.Mehlitz@nasa.gov> |
---|---|
date | Tue, 21 Apr 2015 00:34:15 -0700 |
parents | 61d41facf527 |
children |
line wrap: on
line source
/* * Copyright (C) 2014, United States Government, as represented by the * Administrator of the National Aeronautics and Space Administration. * All rights reserved. * * The Java Pathfinder core (jpf-core) platform is licensed under the * Apache License, Version 2.0 (the "License"); you may not use this file except * in compliance with the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0. * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. */ package gov.nasa.jpf.jvm; import gov.nasa.jpf.Config; import gov.nasa.jpf.JPF; import gov.nasa.jpf.util.JPFLogger; import gov.nasa.jpf.vm.ClassFileContainer; import gov.nasa.jpf.vm.ClassInfo; import gov.nasa.jpf.vm.ClassLoaderInfo; import gov.nasa.jpf.vm.ClassParseException; import gov.nasa.jpf.vm.MethodInfo; import gov.nasa.jpf.vm.SystemClassLoaderInfo; import gov.nasa.jpf.vm.VM; import java.io.File; import java.io.IOException; /** * a SystemClassLoaderInfo that reads standard Java classfiles from *.class and *.jar files, and creates code using a concrete * value JVM instruction set */ public class JVMSystemClassLoaderInfo extends SystemClassLoaderInfo { static JPFLogger log = JPF.getLogger("class"); protected JVMCodeBuilder defaultCodeBuilder; public JVMSystemClassLoaderInfo (VM vm, int appId) { super(vm, appId); defaultCodeBuilder = createDefaultCodeBuilder(config, appId); JVMClassInfo.init(config); // now we can notify vm.registerClassLoader(this); } /** * override this if you need a different default CodeBuilder */ protected JVMCodeBuilder createDefaultCodeBuilder (Config config, int appId) { String key = config.getIndexableKey("jvm.insn_factory.class", appId); JVMInstructionFactory insnFactory = config.getEssentialInstance(key, JVMInstructionFactory.class); return new JVMCodeBuilder(insnFactory); } @Override protected ClassFileContainer createClassFileContainer (String spec) { int i = spec.indexOf(".jar"); if (i > 0) { // its a jar int j = i + 4; int len = spec.length(); String jarPath; String pathPrefix = null; File jarFile; if (j == len) { // no path prefix, plain jar jarPath = spec; } else { if (spec.charAt(j) == '/') { pathPrefix = spec.substring(j); jarPath = spec.substring(0, j); } else { return null; } } jarFile = new File(jarPath); if (jarFile.isFile()) { try { return new JarClassFileContainer(jarFile, pathPrefix); } catch (IOException ix) { return null; } } else { return null; } } else { // a dir File dir = new File(spec); if (dir.isDirectory()) { return new DirClassFileContainer(dir); } else { return null; } } } protected void addSystemBootClassPath () { String v = System.getProperty("sun.boot.class.path"); if (v != null) { for (String pn : v.split(File.pathSeparator)) { if (pn != null && !pn.isEmpty()) { ClassFileContainer cfc = createClassFileContainer(pn); if (cfc != null) { cp.addClassFileContainer(cfc); } } } } else { // Hmm, maybe we are not executing on OpenJDK } } /** * this is the main method to create the ClassPath, which is called from the ctor */ @Override protected void initializeSystemClassPath (VM vm, int appId) { Config conf = vm.getConfig(); File[] pathElements; // explicit "classpath[.id]" settings have precedence pathElements = getPathElements(conf, "classpath", appId); if (pathElements != null) { for (File f : pathElements) { addClassPathElement(f.getAbsolutePath()); } } // we optionally append boot_classpath pathElements = getPathElements(conf, "vm.boot_classpath", appId); if (pathElements != null) { for (File f : pathElements) { if (f.getName().equals("<system>")) { addSystemBootClassPath(); } else { addClassPathElement( f.getAbsolutePath()); } } } log.info("collected system classpath: ", cp); } /** * override this if you have different CodeBuilders for different types * NOTE - this CodeBuilder is not completely initialized yet, clients still have to call startMethod(mi) on it */ protected JVMCodeBuilder getCodeBuilder (String clsName) { return defaultCodeBuilder; } /** * used for automatically created code such as AnnotationProxies, direct calls, native calls and run starts * NOTE - this cannot be called recursively or concurrently */ protected JVMCodeBuilder getSystemCodeBuilder (ClassFile cf, MethodInfo mi) { defaultCodeBuilder.reset(cf, mi); return defaultCodeBuilder; } @Override protected ClassInfo createClassInfo (String clsName, String url, byte[] data, ClassLoaderInfo definingLoader) throws ClassParseException { ClassFile cf = new ClassFile(data); JVMCodeBuilder cb = getCodeBuilder(clsName); ClassInfo ci = new JVMClassInfo(clsName, definingLoader, cf, url, cb); setAttributes(ci); return ci; } }