Mercurial > hg > Members > kono > jpf-core

view src/main/gov/nasa/jpf/jvm/bytecode/JVMInstructionVisitor.java @ 24:6774e2e08d37

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
the fix I would have liked to avoid - apparently hotspot internally does nested locking during class init, which can lead to deadlocks such as described in http://ternarysearch.blogspot.ru/2013/07/static-initialization-deadlock.html. Actually, it's not a regular deadlock since core dumps still list the threads as runnable, althouth it doesn't seem to be a livelock either. In any case, it can be simulated by nested locking and clinit execution, and it is such a serious defect that we want to be able to catch it. The general mechanism is to replace the disparate (but properly ordered) direct clinit calls of the generic ClassInfo.initializeClass() with a single sythetic method that includes all required locking (bottom up), clinit calls / class status change (top down), and unlocking (top down). We also need to add a synthetic insn to defer changing the class status of classes that don't have clinits(), or otherwise the correct lock/unlock order will not amount to anything if the hierarchy is entered through one of the clinit-absent classes. Now we get proper deadlocks if there are concurrent cyclic dependencies during class resolution. However, this can be such a state exploder that we certainly don't want this as the default behavior, especially since it probably is hotspot specific. Nested class init locking is therefore controlled by jvm.nested_init and respective jvm.nested_init.include/exclude options. Added a NestedInitTest to demonstrate use. Thanks to Lilia Abdulina for bringing this long forgotten issue up In the wake of nested locks, there were a number of cases to fix that implicitly relied on absent clinits because clients were not properly checking for re-execution (most notably java.util.Exchanger). This mostly came in through MJIEnv.newObject/ElementInfo. We might turn ClinitRequired into a handled exception at some point, to catch such cases during compilation. Added a UnknownJPFClass exception (in analogy to ClinitRequired), to make clients aware of failed class load attempts/reasons. fixed Exchanger peer, which was not giving up the lock when timing out. This is an example of a lockfree wait op that can time out. Basically, ThreadInfo.isWaiting() needs to be complemented by a isWaitingOrTimedOut(), and ElementInfo.notifies0() has to be aware of it fixed NPE when setting report.probe_interval in tests, which was missing that it had to create a stat object
author Peter Mehlitz <Peter.C.Mehlitz@nasa.gov>
date Tue, 21 Apr 2015 00:34:15 -0700
parents 61d41facf527
children
line wrap: on
line source

/*
 * Copyright (C) 2014, United States Government, as represented by the
 * Administrator of the National Aeronautics and Space Administration.
 * All rights reserved.
 *
 * The Java Pathfinder core (jpf-core) platform is licensed under the
 * Apache License, Version 2.0 (the "License"); you may not use this file except
 * in compliance with the License. You may obtain a copy of the License at
 * 
 *        http://www.apache.org/licenses/LICENSE-2.0. 
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and 
 * limitations under the License.
 */
package gov.nasa.jpf.jvm.bytecode;

import gov.nasa.jpf.vm.Instruction;

public interface JVMInstructionVisitor {

	public void visit(Instruction ins);
	public void visit(AALOAD ins);
	public void visit(AASTORE ins);
	public void visit(ACONST_NULL ins);
	public void visit(ALOAD ins);
	public void visit(ANEWARRAY ins);
	public void visit(ARETURN ins);
	public void visit(JVMArrayElementInstruction ins);
	public void visit(ARRAYLENGTH ins);
	public void visit(ArrayLoadInstruction ins);
	public void visit(ArrayStoreInstruction ins);
	public void visit(ASTORE ins);
	public void visit(ATHROW ins);
	public void visit(BALOAD ins);
	public void visit(BASTORE ins);
	public void visit(BIPUSH ins);
	public void visit(CALOAD ins);
	public void visit(CASTORE ins);
	public void visit(CHECKCAST ins);
	public void visit(D2F ins);
	public void visit(D2I ins);
	public void visit(D2L ins);
	public void visit(DADD ins);
	public void visit(DALOAD ins);
	public void visit(DASTORE ins);
	public void visit(DCMPG ins);
	public void visit(DCMPL ins);
	public void visit(DCONST ins);
	public void visit(DDIV ins);
  public void visit(DIRECTCALLRETURN ins);
	public void visit(DLOAD ins);
	public void visit(DMUL ins);
	public void visit(DNEG ins);
	public void visit(DREM ins);
	public void visit(DRETURN ins);
	public void visit(DSTORE ins);
	public void visit(DSUB ins);
	public void visit(DUP_X1 ins);
	public void visit(DUP_X2 ins);
	public void visit(DUP ins);
	public void visit(DUP2_X1 ins);
	public void visit(DUP2_X2 ins);
	public void visit(DUP2 ins);
  public void visit(EXECUTENATIVE ins);
	public void visit(F2D ins);
	public void visit(F2I ins);
	public void visit(FADD ins);
	public void visit(FALOAD ins);
	public void visit(FASTORE ins);
	public void visit(FCMPL ins);
	public void visit(FCONST ins);
	public void visit(FDIV ins);
	public void visit(JVMFieldInstruction ins);
	public void visit(FLOAD ins);
	public void visit(FMUL ins);
	public void visit(FNEG ins);
	public void visit(FREM ins);
	public void visit(FRETURN ins);
	public void visit(FSTORE ins);
	public void visit(FSUB ins);
	public void visit(GETFIELD ins);
	public void visit(GETSTATIC ins);
	public void visit(GOTO_W ins);
	public void visit(GOTO ins);
	public void visit(I2B ins);
	public void visit(I2C ins);
	public void visit(I2D ins);
	public void visit(I2F ins);
	public void visit(I2L ins);
	public void visit(I2S ins);
	public void visit(IADD ins);
	public void visit(IALOAD ins);
	public void visit(IAND ins);
	public void visit(IASTORE ins);
	public void visit(ICONST ins);
	public void visit(IDIV ins);
	public void visit(IF_ACMPEQ ins);
	public void visit(IF_ACMPNE ins);
	public void visit(IF_ICMPEQ ins);
	public void visit(IF_ICMPGE ins);
	public void visit(IF_ICMPGT ins);
	public void visit(IF_ICMPLE ins);
	public void visit(IF_ICMPLT ins);
	public void visit(IF_ICMPNE ins);
	public void visit(IFEQ ins);
	public void visit(IFGE ins);
	public void visit(IFGT ins);
	public void visit(IfInstruction ins);
	public void visit(IFLE ins);
	public void visit(IFLT ins);
	public void visit(IFNE ins);
	public void visit(IFNONNULL ins);
	public void visit(IFNULL ins);
	public void visit(IINC ins);
	public void visit(ILOAD ins);
	public void visit(IMUL ins);
	public void visit(INEG ins);
	public void visit(JVMInstanceFieldInstruction ins);
	public void visit(InstanceInvocation ins);
	public void visit(INSTANCEOF ins);
	public void visit(INVOKECG ins);
	public void visit(INVOKECLINIT ins);
	public void visit(JVMInvokeInstruction ins);
	public void visit(INVOKEINTERFACE ins);
	public void visit(INVOKESPECIAL ins);
	public void visit(INVOKESTATIC ins);
	public void visit(INVOKEVIRTUAL ins);
	public void visit(IOR ins);
	public void visit(IREM ins);
	public void visit(IRETURN ins);
	public void visit(ISHL ins);
	public void visit(ISHR ins);
	public void visit(ISTORE ins);
	public void visit(ISUB ins);
	public void visit(IUSHR ins);
	public void visit(IXOR ins);
	public void visit(JSR_W ins);
	public void visit(JSR ins);
	public void visit(L2D ins);
	public void visit(L2F ins);
	public void visit(L2I ins);
	public void visit(LADD ins);
	public void visit(LALOAD ins);
	public void visit(LAND ins);
	public void visit(LASTORE ins);
	public void visit(LCMP ins);
	public void visit(LCONST ins);
	public void visit(LDC_W ins);
	public void visit(LDC ins);
	public void visit(LDC2_W ins);
	public void visit(LDIV ins);
	public void visit(LLOAD ins);
	public void visit(LMUL ins);
	public void visit(LNEG ins);
	public void visit(JVMLocalVariableInstruction ins);
	public void visit(LockInstruction ins);
	public void visit(LongArrayLoadInstruction ins);
	public void visit(LongArrayStoreInstruction ins);
	public void visit(LOOKUPSWITCH ins);
	public void visit(LOR ins);
	public void visit(LREM ins);
	public void visit(LRETURN ins);
	public void visit(LSHL ins);
	public void visit(LSHR ins);
	public void visit(LSTORE ins);
	public void visit(LSUB ins);
	public void visit(LUSHR ins);
	public void visit(LXOR ins);
	public void visit(MONITORENTER ins);
	public void visit(MONITOREXIT ins);
	public void visit(MULTIANEWARRAY ins);
  public void visit(NATIVERETURN ins);
	public void visit(NEW ins);
	public void visit(NEWARRAY ins);
	public void visit(NOP ins);
	public void visit(POP ins);
	public void visit(POP2 ins);
	public void visit(PUTFIELD ins);
	public void visit(PUTSTATIC ins);
	public void visit(RET ins);
	public void visit(RETURN ins);
	public void visit(JVMReturnInstruction ins);
	public void visit(SALOAD ins);
	public void visit(SASTORE ins);
	public void visit(SIPUSH ins);
	public void visit(JVMStaticFieldInstruction ins);
	/**public void visit(StoreInstruction ins);**/ // neha: this is just an interface, not implemented
	public void visit(SWAP ins);
	public void visit(SwitchInstruction ins);
	public void visit(TABLESWITCH ins);
	/**public void visit(VariableAccessor ins);**/ // neha: this is just an interface, not implemented
	public void visit(VirtualInvocation ins);
	public void visit(WIDE ins);
}