Mercurial > hg > Members > kono > jpf-core
view src/main/gov/nasa/jpf/jvm/bytecode/MONITORENTER.java @ 24:6774e2e08d37
the fix I would have liked to avoid - apparently hotspot internally does nested locking during class init, which can lead to deadlocks such as described in http://ternarysearch.blogspot.ru/2013/07/static-initialization-deadlock.html. Actually, it's not a regular deadlock since core dumps still list the threads as runnable, althouth it doesn't seem to be a livelock either. In any case, it can be simulated by nested locking and clinit execution, and it is such a serious defect that we want to be able to catch it. The general mechanism is to replace the disparate (but properly ordered) direct clinit calls of the generic ClassInfo.initializeClass() with a single sythetic method that includes all required locking (bottom up), clinit calls / class status change (top down), and unlocking (top down). We also need to add a synthetic insn to defer changing the class status of classes that don't have clinits(), or otherwise the correct lock/unlock order will not amount to anything if the hierarchy is entered through one of the clinit-absent classes. Now we get proper deadlocks if there are concurrent cyclic dependencies during class resolution. However, this can be such a state exploder that we certainly don't want this as the default behavior, especially since it probably is hotspot specific. Nested class init locking is therefore controlled by jvm.nested_init and respective jvm.nested_init.include/exclude options. Added a NestedInitTest to demonstrate use. Thanks to Lilia Abdulina for bringing this long forgotten issue up
In the wake of nested locks, there were a number of cases to fix that implicitly relied on absent clinits because clients were not properly checking for re-execution (most notably java.util.Exchanger). This mostly came in through MJIEnv.newObject/ElementInfo. We might turn ClinitRequired into a handled exception at some point, to catch such cases during compilation.
Added a UnknownJPFClass exception (in analogy to ClinitRequired), to make clients aware of failed class load attempts/reasons.
fixed Exchanger peer, which was not giving up the lock when timing out. This is an example of a lockfree wait op that can time out. Basically, ThreadInfo.isWaiting() needs to be complemented by a isWaitingOrTimedOut(), and ElementInfo.notifies0() has to be aware of it
fixed NPE when setting report.probe_interval in tests, which was missing that it had to create a stat object
author | Peter Mehlitz <Peter.C.Mehlitz@nasa.gov> |
---|---|
date | Tue, 21 Apr 2015 00:34:15 -0700 |
parents | 61d41facf527 |
children |
line wrap: on
line source
/* * Copyright (C) 2014, United States Government, as represented by the * Administrator of the National Aeronautics and Space Administration. * All rights reserved. * * The Java Pathfinder core (jpf-core) platform is licensed under the * Apache License, Version 2.0 (the "License"); you may not use this file except * in compliance with the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0. * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. */ package gov.nasa.jpf.jvm.bytecode; import gov.nasa.jpf.JPFException; import gov.nasa.jpf.vm.ElementInfo; import gov.nasa.jpf.vm.Instruction; import gov.nasa.jpf.vm.MJIEnv; import gov.nasa.jpf.vm.Scheduler; import gov.nasa.jpf.vm.StackFrame; import gov.nasa.jpf.vm.ThreadInfo; /** * Enter monitor for object * ..., objectref => ... */ public class MONITORENTER extends LockInstruction { @Override public Instruction execute (ThreadInfo ti) { Scheduler scheduler = ti.getScheduler(); StackFrame frame = ti.getTopFrame(); int objref = frame.peek(); // Don't pop yet before we know we really enter if (objref == MJIEnv.NULL){ return ti.createAndThrowException("java.lang.NullPointerException", "Attempt to acquire lock for null object"); } lastLockRef = objref; ElementInfo ei = ti.getModifiableElementInfo(objref); ei = scheduler.updateObjectSharedness(ti, ei, null); // locks most likely belong to shared objects if (!ti.isLockOwner(ei)){ // we only need to register, block and/or reschedule if this is not a recursive lock if (ei.canLock(ti)) { // record that this thread would lock the object upon next execution if we break the transition // (note this doesn't re-add if already registered) ei.registerLockContender(ti); if (scheduler.setsLockAcquisitionCG(ti, ei)) { // optional scheduling point return this; } } else { // we need to block ei.block(ti); // this means we only re-execute once we can acquire the lock if (scheduler.setsBlockedThreadCG(ti, ei)){ // mandatory scheduling point return this; } throw new JPFException("blocking MONITORENTER without transition break"); } } //--- bottom half or lock acquisition succeeded without transition break frame = ti.getModifiableTopFrame(); // now we need to modify it frame.pop(); ei.lock(ti); // mark object as locked, increment the lockCount, and set the thread as owner return getNext(ti); } @Override public int getByteCode () { return 0xC2; } @Override public void accept(JVMInstructionVisitor insVisitor) { insVisitor.visit(this); } }